Experiments table ux improvements #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolmir
force-pushed
the
experiments-table-ux-improvements
branch
2 times, most recently
from
de00910 to
ea2408e
Compare
wolmir
force-pushed
the
experiments-table-ux-improvements
branch
from
3dd6b4a to
c872abe
Compare
mattseddon
reviewed
Apr 28, 2022
| @@ -14,7 +14,7 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding; | |||
|
|
|||
| // Dark Theme | |||
|
|
|||
| $row-bg-alt-color: rgba(60, 60, 60, 0.7); | |||
| $row-bg-alt-color: var(--vscode-sideBar-background); | |||
There was a problem hiding this comment.
[I] Seems a better color for this might be --vscode-tree-tableOddRowsBackground
Screen.Recording.2022-04-28.at.11.34.51.am.mov
There was a problem hiding this comment.
note that for some reason the dotted lines are not covered again in the above demo
mattseddon
reviewed
Apr 28, 2022
| @@ -14,7 +14,7 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding; | |||
|
|
|||
| // Dark Theme | |||
|
|
|||
| $row-bg-alt-color: rgba(60, 60, 60, 0.7); | |||
| $row-bg-alt-color: var(--vscode-sideBar-background); | |||
| $header-bg-color: #303031; | |||
There was a problem hiding this comment.
[I] We should remove all of these. I've raised a checkbox under #1603
mattseddon
approved these changes
Apr 28, 2022
sroy3
approved these changes
Apr 28, 2022
rogermparent
approved these changes
Apr 28, 2022
|
Code Climate has analyzed commit c98fbbf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following UX improvement requests:
From #1565:
Figma link
From #1597: