Add manual refresh button to missing plots #1754
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M4.681 3H2V2h3.5l.5.5V6H5V4a5 5 0 1 0 4.53-.761l.302-.954A6 6 0 1 1 4.681 3z" | ||
| fill="currentColor" |
There was a problem hiding this comment.
[F] I had to manually add this after running yarn svgr from the root. Did I do something wrong @sroy3?
There was a problem hiding this comment.
That's fine, it happens sometimes. It's because the svg was not created for the purpose we use it. I think we can change the config of svgr to add it for use.
| url: `${this.webview.getWebviewUri(plot.url)}?${getModifiedTime( | ||
| plot.url | ||
| )}` | ||
| url: plot.url |
There was a problem hiding this comment.
[F] We now always send the record for the revision but the URL will be undefined. We can then use the revision when we need to send something back for a manual refresh.
webview/src/plots/components/comparisonTable/ComparisonTableRow.test.tsx
Show resolved
Hide resolved
| @@ -83,6 +83,9 @@ $gap: 4px; | |||
|
|
|||
| .missing { | |||
| background-color: $bg-color; | |||
| border-style: solid; | |||
| border-width: thin; | |||
| border-color: $watermark-color; | |||
There was a problem hiding this comment.
[Q] Can anyone help me line up this bottom border:
?
There was a problem hiding this comment.
Adding vertical-align: middle to webview/src/plots/components/comparisonTable/styles.module.scss's .cell img rule gets you most of the way there:
top and bottom do the same, as long as it's not the default value.
There was a problem hiding this comment.
Zooming in on storybook does make some crazy stuff happen, though:
There was a problem hiding this comment.
@rogermparent is this new or existing and can it be recreated in VS Code? Just FYI, the refresh button will likely get dropped once we have the top ribbon in the webview.
There was a problem hiding this comment.
The CSS fix is something I added onto this branch locally, and I just replicated both the mostly-fixed and zoomed in weird state in VSCode itself
Normal state with new CSS (you can see the placeholder is still ~1px larger than normal plots on all sides):
Excessively zoomed in with new CSS:
Emphasis on excessively, while technically replicable in VS Code it's far from a real use case so could be considered low priority.
|
Code Climate has analyzed commit d845caa and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Relates to #1649 & #1670.
This PR adds a refresh button to "missing images" in the comparison table:
The underlying action/message that the new button uses can be reused when we add the top ribbon into the plots webview.
Added this comment to one of the original issues re multiple plots being missing: