Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiments table style for all theme #829

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Experiments table style for all theme #829

merged 4 commits into from
Sep 21, 2021

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Sep 20, 2021 •
edited
Loading

Screen Shot 2021-09-20 at 4 43 05 PM

Screen Shot 2021-09-20 at 4 42 48 PM

@sroy3 sroy3 added the product PR that affects product label Sep 20, 2021
@sroy3 sroy3 self-assigned this Sep 20, 2021
@sroy3 sroy3 marked this pull request as ready for review September 20, 2021 20:45
@sroy3
Copy link
Contributor Author

sroy3 commented Sep 20, 2021

Not sure I'm really liking the light theme stuff at the end only. I'll move stuff back up with the rest with a mixin or something.

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2021

Code Climate has analyzed commit 4678f92 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.0% change).

View more on Code Climate.

rogermparent
rogermparent approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to me! We'll probably want to do something in the future about the params/metrics column labels and date field having pretty low contrast on the light theme, but they're passable enough here that I'm comfortable letting this one through.

@sroy3 sroy3 merged commit 7abe21b into master Sep 21, 2021
@sroy3 sroy3 deleted the better-theme-change branch September 21, 2021 16:42
@shcheklein
Copy link
Member

@sroy3 good stuff! Let's create a ticket for @yalozhkin to create a color palette for the light mode.

@mattseddon
Copy link
Member

@sroy3 good stuff! Let's create a ticket for @yalozhkin to create a color palette for the light mode.

Relates to the checkbox in #175 (#175 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent approved these changes

Assignees

@sroy3 sroy3

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sroy3 @shcheklein @mattseddon @rogermparent