Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double slashes in URLs get swallowed #182

Closed
alaz opened this issue Jun 20, 2017 · 3 comments
Closed

Double slashes in URLs get swallowed #182

alaz opened this issue Jun 20, 2017 · 3 comments

Comments

@alaz
Copy link

alaz commented Jun 20, 2017

I am specifying a CDN server in path option, e.g.

path: 'https://assets.server/path',

The problem is that the resulting HTML file contains malformed URLs like in the following fragment:

<link rel="apple-touch-icon" sizes="76x76" href="https:/assets.server/path/apple-touch-icon-76x76.png">
<link rel="apple-touch-icon" sizes="114x114" href="https:/assets.server/path/apple-touch-icon-114x114.png">
<link rel="apple-touch-icon" sizes="120x120" href="https:/assets.server/path/apple-touch-icon-120x120.png">
@alaz
Copy link
Author

alaz commented Jun 20, 2017 •
edited
Loading

Ah, I found #116. I have these versions:

$ yarn list gulp-favicons favicons
yarn list v0.24.6
├─ [email protected]
└─ [email protected]

@levibuzolic
Copy link

Hit this bug too, cause is here:

https://github.com/evilebottnawi/favicons/blob/4f6e8bd19115c2b0067e28f9df349905aea2d814/helpers.js#L45

Should maybe consider not using path.join() as it's not appropriate for joining web URLs -- path.join is designed to overcome inconsistencies in directory separators in OSs. I'll see if I can put up a PR.

@Heymdall Heymdall mentioned this issue Aug 2, 2017
Closed
@davidhellmann
Copy link

Hm any news here? Have the same problem :/

@brunocodutra brunocodutra mentioned this issue Mar 30, 2018
Merged
brunocodutra added a commit that referenced this issue Mar 31, 2018
@brunocodutra
add regression tests for #182
a32a4b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alaz @levibuzolic @davidhellmann