Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory usage by 3x #213

Merged
merged 26 commits into from
Apr 6, 2018
Merged

Reduce memory usage by 3x #213

merged 26 commits into from
Apr 6, 2018

Conversation

brunocodutra
Copy link
Collaborator

@brunocodutra brunocodutra commented Apr 5, 2018 •
edited
Loading

With no measurable impact in time benchmaks.

Fixes #158

@brunocodutra
make the context of helpers local
656fe08
@brunocodutra
promisify helpers.General.source
cd99c1d
@brunocodutra
promisify createPlatform
445c8d0
@brunocodutra
promisify create
3e1dbfe
@brunocodutra
promisify helpers.Files.create
2020b09
@brunocodutra
promisify helpers.Images.read
8270f57
@brunocodutra
promisify helpers.Images.resize
fe382ab
@brunocodutra
promisify helpers.Images.create
1527546
@brunocodutra
promisify helpers.Images.composite
6f019ee
@brunocodutra
promisify helpers.Images.getBuffer
afd9e23
@brunocodutra
promisify helpers.Images.nearest
48bf7fc
@brunocodutra
promisify createFavicon
f394875
@brunocodutra
promisify createFavicons
76bc2be
@brunocodutra
promisify createFiles
9489b22
@brunocodutra
promisify helpers.HTML.parse
708df8a
@brunocodutra
promisify createHTML
7b4d680
@brunocodutra
remove undocumented and untested feature
c85c631
@brunocodutra
take advantage of the promisified functions
483e876
@brunocodutra
setup babel to add polyfills as needed
3c760be
@brunocodutra
fix error message
b317808
@brunocodutra
inline Images.read into Images.nearest
f6fd5d6
@brunocodutra
inline Images.getBuffer into Images.composite
97eea4d
@brunocodutra
only read mask.png and overlay.png once from file
af23974
@brunocodutra
fix failure tests on windows
76952e9
@brunocodutra
create platforms serially for 3x less memory usage
68ab75d
@brunocodutra
merge Images.nearest and Images.resize into Images.render
a73e1f4
@brunocodutra
Copy link
Collaborator Author

@evilebottnawi This fixes memory issues that prevented tests from passing on appveyor, so please mark appveyor as required prior to merging.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 406

  • 145 of 151 (96.03%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+7.05%) to 89.571%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.js 40 42 95.24%
src/helpers.js 105 109 96.33%
Files with Coverage Reduction New Missed Lines %
src/index.js 1 89.29%
Totals Coverage Status
Change from base Build 399: 7.05%
Covered Lines: 204
Relevant Lines: 217
💛 - Coveralls

alexander-akait
alexander-akait approved these changes Apr 6, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brunocodutra brunocodutra merged commit 554fa78 into master Apr 6, 2018
@brunocodutra brunocodutra deleted the async branch April 6, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunocodutra @coveralls @alexander-akait