Merge pull request #58 from itk-dev/feature/core-updates

Core updates

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,25 @@
+#### Link to ticket
+
+Please add a link to the ticket being addressed by this change.
+
+#### Description
+
+Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
+
+#### Screenshot of the result
+
+If your change affects the user interface you should include a screenshot of the result with the pull request.
+
+#### Checklist
+
+- [ ] My code is covered by test cases.
+- [ ] My code passes our test (all our tests).
+- [ ] My code passes our static analysis suite.
+- [ ] My code passes our continuous integration process.
+
+If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change 
+should be exempt from the list.
+
+#### Additional comments or questions
+
+If you have any further comments or questions for the reviewer please add them here.

.woodpecker/deployment.yml

@@ -20,10 +20,10 @@ steps:
         from_secret: user
       playbook: 'release'
       pre_up:
-        - itkdev-docker-compose-server run --rm phpfpm vendor/bin/drush --yes cache:rebuild
-        - itkdev-docker-compose-server run --rm phpfpm vendor/bin/drush --yes deploy
         # Fixes issue with 'Drupal\mysql\Driver\Database\mysql\Connection' not found
         - itkdev-docker-compose-server run --rm phpfpm composer dump-autoload
+        - itkdev-docker-compose-server run --rm phpfpm vendor/bin/drush --yes cache:rebuild
+        - itkdev-docker-compose-server run --rm phpfpm vendor/bin/drush --yes deploy
       cron:
         cron:
           minute: '*/5'

CHANGELOG.md

@@ -8,6 +8,9 @@ See [keep a changelog] for information about writing changes to this log.
 
 ## [Unreleased]
 
+* [PR-58](https://github.com/itk-dev/doner-din-stemme/pull/58)
+  Drupal core and external auth module updates.
+
 * [PR-56](https://github.com/itk-dev/doner-din-stemme/pull/56)
   * Modifies qualify command to only transcribe donations.
   * Makes commands calculating each of the metrics (WER, CER and similar_text)

composer.json

@@ -56,7 +56,8 @@
             "drupal/core-project-message": true,
             "ergebnis/composer-normalize": true,
             "php-http/discovery": true,
-            "phpstan/extension-installer": true
+            "phpstan/extension-installer": true,
+            "tbachert/spi": true
         },
         "sort-packages": true
     },

recipes/README.txt

@@ -0,0 +1,9 @@
+Recipes allow the automation of Drupal module and theme installation and
+configuration.
+
+WHAT TO PLACE IN THIS DIRECTORY?
+--------------------------------
+
+Placing downloaded and custom recipes in this directory separates downloaded and
+custom recipes from Drupal core's recipes. This allows Drupal core to be updated
+without overwriting these files.

web/.htaccess

@@ -22,6 +22,9 @@ DirectoryIndex index.php index.html index.htm
 AddType image/svg+xml svg svgz
 AddEncoding gzip svgz
 
+# Add correct encoding for webp.
+AddType image/webp .webp
+
 # Most of the following PHP settings cannot be changed at runtime. See
 # sites/default/default.settings.php and
 # Drupal\Core\DrupalKernel::bootEnvironment() for settings that can be

web/modules/custom/giv_din_stemme/giv_din_stemme.module

@@ -78,16 +78,16 @@ function giv_din_stemme_theme(array $existing, string $type, string $theme, stri
 /**
  * Implements hook_theme_suggestions_form_alter().
  */
-function giv_din_stemme_theme_suggestions_form_alter(array &$suggestions, array $variables) {
+function giv_din_stemme_theme_suggestions_form_alter(array &$suggestions, array $variables): void {
   if (isset($variables['element']['#form_id'])) {
     $suggestions[] = 'form__' . $variables['element']['#form_id'];
-  };
+  }
 }
 
 /**
  * Implements hook_form_FORMID_alter().
  */
-function giv_din_stemme_form_user_form_alter(&$form, FormStateInterface $form_state, $form_id) {
+function giv_din_stemme_form_user_form_alter(&$form, FormStateInterface $form_state, $form_id): void {
   // Add redirect submit handler.
   $form['actions']['submit']['#submit'][] = 'giv_din_stemme_redirect';
 
@@ -127,7 +127,7 @@ function giv_din_stemme_form_user_form_alter(&$form, FormStateInterface $form_st
  * @param \Drupal\Core\Form\FormStateInterface $form_state
  *   The state of the form.
  */
-function giv_din_stemme_redirect(array &$form, FormStateInterface $form_state) {
+function giv_din_stemme_redirect(array &$form, FormStateInterface $form_state): void {
   $form_state->setRedirect('giv_din_stemme.permissions');
 }
 

web/sites/default/default.services.yml

@@ -38,6 +38,10 @@ parameters:
     # To maximize compatibility and normalize the behavior across user agents,
     # the cookie domain should start with a dot.
     #
+    # Sessions themselves will only be synchronized across subdomains if they
+    # are all served from the same Drupal installation or if some other session
+    # sharing mechanism is implemented.
+    #
     # @default none
     # cookie_domain: '.example.com'
     #
@@ -47,23 +51,6 @@ parameters:
     # information.
     # @default no value
     cookie_samesite: Lax
-    #
-    # Set the session ID string length. The length can be between 22 to 256. The
-    # PHP recommended value is 48. See
-    # https://www.php.net/manual/session.security.ini.php for more information.
-    # This value should be kept in sync with
-    # \Drupal\Core\Session\SessionConfiguration::__construct()
-    # @default 48
-    sid_length: 48
-    #
-    # Set the number of bits in encoded session ID character. The possible
-    # values are '4' (0-9, a-f), '5' (0-9, a-v), and '6' (0-9, a-z, A-Z, "-",
-    # ","). The PHP recommended value is 6. See
-    # https://www.php.net/manual/session.security.ini.php for more information.
-    # This value should be kept in sync with
-    # \Drupal\Core\Session\SessionConfiguration::__construct()
-    # @default 6
-    sid_bits_per_character: 6
     # By default, Drupal generates a session cookie name based on the full
     # domain name. Set the name_suffix to a short random string to ensure this
     # session cookie name is unique on different installations on the same
@@ -216,20 +203,39 @@ parameters:
   # Note: By default the configuration is disabled.
   cors.config:
     enabled: false
-    # Specify allowed headers, like 'x-allowed-header'.
+    # Specifies allowed headers and sets the Access-Control-Allow-Headers
+    # header. For example, ['X-Custom-Header']. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers
     allowedHeaders: []
-    # Specify allowed request methods, specify ['*'] to allow all possible ones.
+    # Specifies allowed request methods and sets the
+    # Access-Control-Allow-Methods header. For example, ['POST', 'GET',
+    # 'OPTIONS'] or ['*'] to allow all. Note the wildcard is not yet implemented
+    # in all browsers. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Methods
     allowedMethods: []
-    # Configure requests allowed from specific origins. Do not include trailing
-    # slashes with URLs.
+    # Configure requests allowed from specific origins and sets the
+    # Access-Control-Allow-Origin header. For example,
+    # ['https://www.drupal.org'] or ['*'] to allow any origin to access your
+    # resource. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin
     allowedOrigins: ['*']
     # Configure requests allowed from origins, matching against regex patterns.
     allowedOriginsPatterns: []
-    # Sets the Access-Control-Expose-Headers header.
+    # Sets the Access-Control-Expose-Headers header. The default is false which
+    # means the header will not be set. To set the header use a comma delimited
+    # list within square brackets. For example, ['Content-Type', 'Expires'] or
+    # ['*'] to expose all headers. Setting exposedHeaders: ['*'] will result in
+    # a Access-Control-Expose-Headers: * response header. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Expose-Headers
     exposedHeaders: false
-    # Sets the Access-Control-Max-Age header.
+    # Setting Access-Control-Max-Age header value to '0' or false will omit this
+    # from the response. However, setting it to '-1' will explicitly disable
+    # caching. For example, setting the value to 600 will cache results of a
+    # preflight request for 10 minutes. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Max-Age
     maxAge: false
-    # Sets the Access-Control-Allow-Credentials header.
+    # Sets the Access-Control-Allow-Credentials header if set to true. See
+    # https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Credentials
     supportsCredentials: false
 
   queue.config: