Feature/donation count and duration state #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jekuaitk
commented
Aug 26, 2024
•
jekuaitk
commented
- Keeps total donation count and duration in state
- Updates state when a new donation is made
- Disables cache on front-page
jekuaitk
force-pushed
the
feature/donation-count-and-duration-state
branch
from
677b014 to
4b377c1
Compare
jekuaitk
force-pushed
the
feature/donation-count-and-duration-state
branch
from
f89b628 to
54ab259
Compare
rimi-itk
requested changes
Aug 26, 2024
Comment on lines
+276
to
+277
| $this->helper->updateTotalDonationDuration((int) $request->request->get('duration')); | ||
| $this->helper->updateTotalNumberOfDonations(); |
There was a problem hiding this comment.
Are you throwing away metadata here? Why?
Co-authored-by: Mikkel Ricky <[email protected]>
Co-authored-by: Mikkel Ricky <[email protected]>
rimi-itk
requested changes
Aug 27, 2024
Comment on lines
107
to
109
| $currentTotal = $this->getTotalNumberOfDonations(); | ||
|
|
||
| if (is_null($currentTotal)) { | ||
| $this->state->set(self::GIV_DIN_STEMME_DONATION_COUNT_STATE_KEY, 1); | ||
| } | ||
| else { | ||
| $this->state->set(self::GIV_DIN_STEMME_DONATION_COUNT_STATE_KEY, $currentTotal + 1); | ||
| } | ||
| $this->state->set(self::GIV_DIN_STEMME_DONATION_COUNT_STATE_KEY, ($currentTotal ?? 0) + 1); |
There was a problem hiding this comment.
Handle this like you handle the total above.
Comment on lines
+118
to
+119
| // Attempt acquiring lock, wait if failed. | ||
| // @see https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Lock%21LockBackendInterface.php/group/lock/11.x |
rimi-itk
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.