Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/template adjustments #5

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

martinyde
Copy link
Contributor

Config changes

@@ -2,14 +2,14 @@ _core:
default_config_hash: HlN7eAN2N4JIHsYv56V4E7sqC9bS609KwvGFjyD_mgk
langcode: da
uuid: 1ef393ee-f23f-4df7-9e77-dc45afb41d4a
name: 'Doner din stemme'
name: 'Drush Site-Install'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rename this to Giv din stemme?

This link expires in one day and nothing will happen if it is not used.

-- [site:name] team
body: "[user:display-name]\r\n\r\nA request to cancel your account has been made at [site:name].\r\n\r\nYou may now cancel your account on [site:url-brief] by clicking this link or copying and pasting it into your browser:\r\n\r\n[user:cancel-url]\r\n\r\nNOTE: The cancellation of your account is not reversible.\r\n\r\nThis link expires in one day and nothing will happen if it is not used.\r\n\r\n-- [site:name] team"
Copy link
Contributor

@jekuaitk jekuaitk Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should users be allowed to do this? If so, should this be translated?

- 'GET'
defaults:
_controller: '\Drupal\giv_din_stemme\Controller\GivDinStemmeController::login'
_title: 'Samtykke'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say Login, MitID Login or something similar?

Comment on lines 147 to 148
$url = $response->getTargetUrl();
$a = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$url = $response->getTargetUrl();
$a = 1;

@martinyde martinyde merged commit 36debea into release/initial-release Aug 16, 2024
@martinyde martinyde deleted the feature/template-adjustments branch August 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants