3753: WER and CER qualification of donations #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekuaitk
force-pushed
the
feature/wer-and-cer
branch
from
51a7ab2 to
a4bd5ec
Compare
cableman
requested changes
Feb 10, 2025
| } | ||
|
|
||
| $gds->save(); | ||
| $donationIds = $query->accessCheck()->execute(); |
There was a problem hiding this comment.
Do we need the access check, will commands not alway be runned as user 1?
There was a problem hiding this comment.
Commands are actually ran as the anonymous user. The access check however is still needed cf. https://www.drupal.org/node/3201242.
| @@ -95,7 +104,9 @@ public function buildRow(EntityInterface $entity) { | |||
| } | |||
|
|
|||
| $row['whisper_guess'] = $entity->getWhisperGuess() ?? '-'; | |||
| $row['similar_text_score'] = $entity->getWhisperGuessSimilarTextScore() ? round($entity->getWhisperGuessSimilarTextScore(), 2) . '%' : '-'; | |||
| $row['similar_text_score'] = $entity->getWhisperGuessSimilarTextScore() ? (100 - round($entity->getWhisperGuessSimilarTextScore(), 2)) / 100 : '-'; | |||
There was a problem hiding this comment.
Why the math here with /100 when the other do not have changes to the value from the database. Please comment in the code.
There was a problem hiding this comment.
Updated README and added comment explaining why.
To align the similar_text score with WER and CER we report the dissimilarity score as a decimal,
such that all three metrics have 0 being good and 1 (or more) being bad.
jekuaitk
force-pushed
the
feature/wer-and-cer
branch
from
f227f84 to
850ed38
Compare
cableman
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/3753
WER,CERandsimilar_text)Note that previous commands have changed name.