Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add text reading pages #8

Merged
merged 11 commits into from
Aug 23, 2024
Merged

Feature/add text reading pages #8

merged 11 commits into from
Aug 23, 2024

Conversation

jekuaitk
Copy link
Contributor

@jekuaitk jekuaitk commented Aug 20, 2024 •
edited
Loading

  • Adds GivDinStemme entity
  • Adds initial /read/{collection_id}/{delta} pages
  • Adds initial /thank-you page

@jekuaitk jekuaitk requested a review from martinyde August 22, 2024 11:32
@jekuaitk jekuaitk changed the base branch from release/initial-release to develop August 22, 2024 11:33
martinyde
martinyde requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@martinyde martinyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Consider moving some of the controller methods into helper.

@jekuaitk jekuaitk requested review from martinyde and removed request for martinyde August 22, 2024 14:04
@martinyde martinyde merged commit 746436f into develop Aug 23, 2024
7 of 8 checks passed
@martinyde martinyde deleted the feature/add-text-reading-pages branch August 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinyde martinyde martinyde requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jekuaitk @martinyde