Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: draw background into hole between scroll bars #20

Closed
itsayellow opened this issue Nov 2, 2017 · 7 comments
Closed

Mac: draw background into hole between scroll bars #20

itsayellow opened this issue Nov 2, 2017 · 7 comments
Assignees
Labels
bug Something isn't working mac Mac related issues trivial

Comments

@itsayellow
Copy link
Owner

Originally reported by Matthew Clapp (Bitbucket: itsayellow, GitHub: itsayellow)


Screen Shot 2017-11-02 at 12.32.10 AM.png


@itsayellow
Copy link
Owner Author

Original comment by Matthew Clapp (Bitbucket: itsayellow, GitHub: itsayellow)


difficult to consistently reproduce (at least on MacAir Yosemite)

@itsayellow
Copy link
Owner Author

Original comment by Matthew Clapp (Bitbucket: itsayellow, GitHub: itsayellow)


Hard to reproduce this now.

@itsayellow itsayellow added trivial bug Something isn't working labels Jul 3, 2018
@itsayellow itsayellow self-assigned this Jul 3, 2018
@itsayellow itsayellow added the mac Mac related issues label Jul 3, 2018
@itsayellow
Copy link
Owner Author

To reproduce:

  • Start with an image zoom and window size so that only one scrollbar is visible. The image should only be slightly larger than the window so that the scrollbar fills almost the whole scroll area.
  • Zoom in one tick so that both scrollbars are visible. (Making lower-right corner not painted)

This should leave a chunk of the original scroll bar in the lower-right corner on Mac.

@itsayellow
Copy link
Owner Author

Possible fix (hack?)

For Zoom In operation:

  • Check if only one scrollbar is visible
    • If True, then shrink canvas smaller than window, THEN enlarge to final size
    • This should first erase any scrollbar from window, then repaint both.

@itsayellow
Copy link
Owner Author

If above works only need to modify image_scrolled_canvas: set_virt_size_with_min

@itsayellow
Copy link
Owner Author

Or possibly,

  1. Set virtual size to client area size (window size)
  2. Draw a rectangle into lower-right corner of color wx.Window.GetBackgroundColor()
  3. Set virtual size to proper size.

@itsayellow
Copy link
Owner Author

wx.Window.HasScrollbar(self, orient)

itsayellow added a commit that referenced this issue Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mac Mac related issues trivial
Projects
None yet
Development

No branches or pull requests

1 participant