Skip to content

Commit

Permalink
fix(canvas/dialogs): improve apply comments dialog styles like in p…
Browse files Browse the repository at this point in the history
…y `Console` (#91, #86)

- Ensure styles for `[role="dialog"]` are not applied when `[data-comment-id]` attribute is present

Changes summary:
    - Refined the styling for "Apply" comments dialogs to ensure that styles are not applied when the `data-comment-id` attribute is present.
  • Loading branch information
itsmartashub committed Dec 13, 2024
1 parent 5ba1a5c commit f4a4ad8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
10 changes: 5 additions & 5 deletions src/sass/elements/_canvas.scss
Original file line number Diff line number Diff line change
Expand Up @@ -97,16 +97,16 @@
section.popover.h-full.w-full {
background-color: var(--c-bg-cm) !important;

/* Resizing line */
.cursor-ns-resize.bg-token-text-quaternary {
background-color: hsla(var(--accent-hsl) / .5) !important;
}

/* Header of canvas with title, coppy btn */
header[class*="@container"] {
background-color: var(--c-bg-cm);
}

/* Resizing line */
.cursor-ns-resize.bg-token-text-quaternary {
background-color: hsla(var(--accent-hsl) / .5) !important;
}

/* Borders in console */
.border-token-border-xlight {
--border-xlight: hsla(var(--accent-hsl) / .1) !important;
Expand Down
10 changes: 7 additions & 3 deletions src/sass/elements/_dialogs.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/* Dialogs - Settings */
[role='dialog'] {
/* ===================== DIAOGS ====================
not(> [data-comment-id]) - dialog without code comment like in "Run" python code console
*/
[role='dialog']:not(> [data-comment-id]) {
padding: var(--p-dialog) !important;
background-color: var(--c-bg-dialog) !important;
border-radius: var(--br-dialog) !important;
Expand Down Expand Up @@ -83,7 +85,7 @@
text-transform: uppercase;
}

/* "Your invite is valid until December X, 2023" in "YOU'RE INVITED TO PLUS" footer */
/* TODO(remove?) ???? "Your invite is valid until December X, 2023" in "YOU'RE INVITED TO PLUS" footer */
.text-gizmo-gray-500 {
text-align: center;
margin-top: 1rem;
Expand Down Expand Up @@ -547,6 +549,8 @@

}

&:has(> [data-comment-id]) {}

}

html.dark[data-gptheme='oled'] [role='dialog'] {
Expand Down

0 comments on commit f4a4ad8

Please sign in to comment.