Add BACKUP_ON_STARTUP option

[wyne]

Add BACKUP_ON_STARTUP option to configure whether a backup is initiated immediately upon start.

It can be useful to set this to false especially when working on your first configuration. As you iterate on your configuration and restart the backup server often, this will prevent duplicate backups for each restart.

Setting to false will wait for the BACKUP_INTERVAL before the first backup. Additionally, it will wait until a player has been active before initiating a backup according to PAUSE_IF_NO_PLAYERS.

[itzg]

Can you describe your testing approach? From what I'm seeing may not work the way you're wanting in an all cases.

[itzg]

I'm not sure if this is the right place for the conditional. This is for the case when the server is auto-paused.

Won't the backup call on line 605 happen still?

[wyne]

In practice, this works for me as I expected. I'll take another look if I can figure out a better option.

[itzg]

Please provide your compose file or equivalent used for testing.

[wyne]

I was running into issues with running the current tests on Apple Silicon, so I'll need to revisit those and update the PR.

[wyne]

You're right, the original didn't work for all cases. I think it was working for me because my servers were already up and paused.

I moved the conditional up, which seems more correct. But I'll still do more testing.

Here's the test compose file I used:

# docker-compose.yml
services:
  mc:
    image: itzg/minecraft-server
    restart: always
    tty: true
    stdin_open: true
    ports:
      - "25565:25565"
    environment:
      EULA: "TRUE"
      ENABLE_AUTOPAUSE: "TRUE"
      AUTOPAUSE_TIMEOUT_EST: 30
    volumes:
      - "./data:/data"

  backup:
    restart: "no"
    build: .
    depends_on:
      mc:
        condition: service_healthy
    environment:
      BACKUP_INTERVAL: "1h"
      # BACKUP_ON_STARTUP: false
      RCON_HOST: mc
      INITIAL_DELAY: 0
      PAUSE_IF_NO_PLAYERS: true
    deploy:
      resources:
        limits:
          memory: 2G
    volumes:
      - "./data:/data:ro"
      - "./backups:/backups"

[itzg]

Yep, that's better 😀