Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HTTP::Server::ClientError" and "Broken pipe (IO::Error)" spam the log #1416

Open
TheFrenchGhosty opened this issue Oct 16, 2020 · 8 comments
Labels
bug Something isn't working type:server-side type:upstream The problem lies in one of the libraries, not in Invidious itself

Comments

@TheFrenchGhosty
Copy link
Member

This does spam the log:

   from ../../../usr/lib/crystal/io/evented.cr:156:7 in 'unbuffered_write'
   from ../../../usr/lib/crystal/io/buffered.cr:217:5 in 'unbuffered_flush'
   from ../../../usr/lib/crystal/io/buffered.cr:219:5 in 'close'
   from ../../../usr/lib/crystal/http/server/request_processor.cr:62:11 in 'process'
   from ../../../usr/lib/crystal/http/server.cr:498:5 in '->'
   from ../../../usr/lib/crystal/primitives.cr:255:3 in 'run'
   from ???
 Unhandled exception in spawn: Error while flushing data to the client (HTTP::Server::ClientError)
   from ../../../usr/lib/crystal/http/server/response.cr:258:9 in 'unbuffered_flush'
   from ../../../usr/lib/crystal/io/buffered.cr:219:5 in 'close'
   from ../../../usr/lib/crystal/http/server/request_processor.cr:62:11 in 'process'
   from ../../../usr/lib/crystal/http/server.cr:498:5 in '->'
   from ../../../usr/lib/crystal/primitives.cr:255:3 in 'run'
   from ???
 Caused by: Error writing to socket: Broken pipe (IO::Error)

However, this doesn't seem to cause any actual problem.

@SamantazFox
Copy link
Member

@TheFrenchGhosty is is still a problem?

@unixfox
Copy link
Member

unixfox commented Jun 27, 2021

@TheFrenchGhosty is is still a problem?

Yes it is, up to this day I still very frequently get this issue.

@unixfox
Copy link
Member

unixfox commented Jun 30, 2021

Related to crystal-lang/crystal#9065

This exception occurs when a client closed the connection before the HTTP server sent the actual data, the HTTP server then fail to send the data because it isn't connected with the client anymore.

SamantazFox pushed a commit that referenced this issue Jul 14, 2021
Related to #1416, it doesn't really fix the real error, but instead mutes the exception message.

Like explained in #1416, this "exception Error" while flushing the client data doesn't harm the client-server connection. However, this exception message continuously spams the logs and makes debugging and error finding really difficult.
@SamantazFox
Copy link
Member

Closed by #2235

@unixfox
Copy link
Member

unixfox commented Sep 1, 2021

Closed by #2235

I thought I wouldn't close this issue until we fix the original problem.

@TheFrenchGhosty TheFrenchGhosty added the blocked require something else first label Sep 2, 2021
@TheFrenchGhosty
Copy link
Member Author

TheFrenchGhosty commented Sep 2, 2021

Still an issue. This is an upstream bug.

@SamantazFox
Copy link
Member

SamantazFox commented Sep 2, 2021

Ah, yeah: crystal-lang/crystal#9065

@SamantazFox SamantazFox added type:upstream The problem lies in one of the libraries, not in Invidious itself and removed blocked require something else first labels Dec 7, 2021
@github-actions github-actions bot added the stale label Dec 7, 2022
@unixfox unixfox removed the stale label Dec 7, 2022
@iv-org iv-org deleted a comment from github-actions bot Dec 7, 2022
Copy link

github-actions bot commented Dec 8, 2023

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type:server-side type:upstream The problem lies in one of the libraries, not in Invidious itself
Projects
Status: Upstream issues
Development

No branches or pull requests

4 participants