[Bug] Regression - Invidious doesn't fall-back to non-DASH if a DASH stream isn't available

[TheFrenchGhosty]

Describe the bug

Invidious used to automatically fall-back to &quality=medium when no DASH stream was available. It doesn't anymore, and just try to load a non-existing stream forever.

Steps to Reproduce

Try to play a video that doesn't have a DASH stream available yet (newly uploaded videos - easier to reproduce on newly uploaded hours long videos)

Logs

The browser console reports:

Uncaught Error: refreshMedia_ must take a media id

Screenshots

N/A

Additional context

N/A

[unixfox]

And I don't recall that being the case. When dash fails, it fails forever, and it will never try to load a non dash stream.

[TheFrenchGhosty]

When dash fails, it fails forever, and it will never try to load a non dash stream.

Unless I remember wrong, Invidious used to automatically add &quality=medium to the URL, meaning this is indeed a regression.

[unixfox]

Invidious never redirected to another page when dash fail.

The only thing I can see in the code is that invidious will try to redirect to non dash if it doesn't find the audio sources: https://github.com/iv-org/invidious/blob/master/src/invidious/routes/watch.cr#L143

You should try to compile an older version of invidious in order to test if it's really a regression. Maybe before I upgraded video.js: #3011

[TheFrenchGhosty]

The only thing I can see in the code is that invidious will try to redirect to non dash if it doesn't find the audio sources: https://github.com/iv-org/invidious/blob/master/src/invidious/routes/watch.cr#L143

If there is in no dash stream, there is no audio source... so isn't it the problem? I maybe understand the function incorrectly.

[unixfox]

Dash is both a video source and audio source at the same time. If there is no audio source then dash will play a video with no sound. We don't want that so we redirect to a non dash stream.

[ghost]

It's mostly 720p streams that stop loading. I don't know why it happens. I always had to stream in 360p.
Edit: It even happens now. For ex, just take this vid as example. It's also instance independent.

[unixfox]

It's mostly 720p streams that stop loading. I don't know why it happens. I always had to stream in 360p.

You are commenting on the incorrect issue, the issue you are looking for is this one: #3025

[github-actions]

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.