Bump videojs to 7.12.1

[unixfox]

Related to #2848

Help with the issue in #2850

Fixes #2941
Fixes #2385
Fixes #2065
Fixes #2942

• This PR bumps video.js to the latest version 7.12.1. The versions after that seems to have some issues with the videojs-http-source-selector plugin which is by the way unmaintained, we should look into removing it with another way to offer a quality selection.
  Webm is not served anymore through the manifest dash API because webm with dash is unfortunately not supported:

  • DASH Stream (webm) not working with VideoJS videojs/video.js#7267
  • https://github.com/videojs/http-streaming/blob/main/docs/supported-features.md#container-formats

• I've added a small piece of code into the player javascript code so that it automatically reload the player on errors when using DASH, documentation: https://github.com/videojs/http-streaming/blob/main/docs/reload-source-on-error.md

• Also related to [Enhancement] Detect rolling cipher/video encryption and force proxy or do not load the video page if proxy disabled. #2850, videojs and the default video player of the browser (no JS) will try to proxy the video/audio if it encounters an error. Change in silvermine videojs-quality-selector library is in Add the ability to hide quality options videojs-quality-selector#1

• Finally, videojs will now send the range parameter as a query string in order to avoid any preflight requests. This is very useful for proxying the video data through a server under another domain. That's what Piped is already doing.

---

Nice to have

• Have a better retry in case of errors, don't try indefinitely every 10 seconds. Stop after X retries then continue later.

[unixfox]

Ideally, I would like to still offer by default webm in the manifest API but not offering webm to video.js when it requests the dash manifest.

[unixfox]

Bugs remaining:

• When 1080p is forced in the preferences then changing the quality from the quality icon to 720p or another quality then the lowest quality will be chosen.
• When auto is set and then changing quality from the quality icon to 1080p then the player will throw an error. This only happen if done at the start of the video, when it is hasn't loaded enough buffer. Example video that does that: http://127.0.0.1:3000/watch?v=OYyVmTdFjJA

[unixfox]

Okay, videojs 7.12.1 doesn't seem to break videojs-http-source-selector. There is no repeatable video append of errors when switching to 1080p in the quality selector when auto is set in the preferences.

[unixfox]

I've added more code! One major part is that videojs will now try to proxy the video if it encounters an error at the start of the playback of the video.
This should greatly reduce the amount of "the media could not be loaded" errors.

I've updated the original description for reflecting this change.

[unixfox]

In testing on https://yewtu.be since 3 days ago.

[unixfox]

Seems to work fine on my end and good to merge.

The "nice to have" list is probably good for another pull request once I've more free time again to work on that.

[davidcollini]

#2942 seems to be fixed aswell :)

[TheFrenchGhosty]

If possible, please replace assets/js/silvermine-videojs-quality-selector.min.js with a non-minified version of it.

[unixfox]

If possible, please replace assets/js/silvermine-videojs-quality-selector.min.js with a non-minified version of it.

Why? It's the point of https://github.com/iv-org/videojs-quality-selector

And it's always been like this, and it's much faster for the browser to load a minified file. If we want to provide the source code then we can do it through a source map: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/SourceMap

[unixfox]

@SamantazFox How do we move forward with this PR? Anything else needed to test before merging?

[SamantazFox]

@unixfox Sorry for the late reply: you've deployed it on your instance, right? If yes, I'm confident that we can merge it without further testing, as I haven't seen any issues related to that.