Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Unregister captcha job" #2519

Closed
wants to merge 3 commits into from

Conversation

syeopite
Copy link
Member

Reverts #2390

Some endpoints like captions can still be blocked.

@syeopite syeopite requested a review from a team as a code owner October 16, 2021 13:56
@syeopite syeopite requested review from unixfox and removed request for a team October 16, 2021 13:56
@unixfox
Copy link
Member

unixfox commented Oct 16, 2021

Google rate limit per endpoint so if the captions are rate limited then the recaptcha job may not be triggered because it wouldn't detect a rate limit on the captions endpoint.

@syeopite
Copy link
Member Author

Ah true. Should we just make the captcha bypass job query that endpoint for detection then?

@syeopite syeopite force-pushed the revert-2390-unrequire-captcha-job branch from 209777a to b23d32c Compare October 27, 2021 11:51
@unixfox
Copy link
Member

unixfox commented Nov 3, 2021

For the RSS I highly doubt this is going to unblock anything as the page doesn't even provide any CAPTCHA to complete:

@unixfox
Copy link
Member

unixfox commented Nov 6, 2021

I'm having the same message for the captions:

<html>
   <head>
      <meta http-equiv="content-type" content="text/html; charset=utf-8"/>
      <title>Sorry...</title>
      <style> body { font-family: verdana, arial, sans-serif; background-color: #fff; color: #000; }</style>
   </head>
   <body>
      <div>
         <table>
            <tr>
               <td><b><font face=sans-serif size=10><font color=#4285f4>G</font><font color=#ea4335>o</font><font color=#fbbc05>o</font><font color=#4285f4>g</font><font color=#34a853>l</font><font color=#ea4335>e</font></font></b></td>
               <td style="text-align: left; vertical-align: bottom; padding-bottom: 15px; width: 50%">
                  <div style="border-bottom: 1px solid #dfdfdf;">Sorry...</div>
               </td>
            </tr>
         </table>
      </div>
      <div style="margin-left: 4em;">
         <h1>We're sorry...</h1>
         <p>... but your computer or network may be sending automated queries. To protect our users, we can't process your request right now.</p>
      </div>
      <div style="margin-left: 4em;">See <a href="https://support.google.com/websearch/answer/86640">Google Help</a> for more information.<br/><br/></div>
      <div style="text-align: center; border-top: 1px solid #dfdfdf;"><a href="https://www.google.com">Google Home</a></div>
   </body>
</html>

Not sure if enabling the anti captcha is going to do anything as there is no captcha presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work In progress
Development

Successfully merging this pull request may close these issues.

2 participants