replicate headers and params made by yt apps #3290
Conversation
| return if request.resource.starts_with? "/sorry/index" | ||
| request.headers["x-youtube-client-name"] ||= "1" | ||
| request.headers["x-youtube-client-version"] ||= "2.20200609" | ||
| # Preserve original cookies and add new YT consent cookie for EU servers | ||
| request.headers["cookie"] = "#{request.headers["cookie"]?}; CONSENT=YES+" | ||
| request.headers["Cookie"] = "#{request.headers["cookie"]?}; CONSENT=YES+" |
There was a problem hiding this comment.
When did we switch to "YES+" here!?
There was a problem hiding this comment.
Uhhh, seems that we've always been using that: 739f610
There was a problem hiding this comment.
For a long time, that's why I did create this PR back in the days: #2207
There was a problem hiding this comment.
Technically CONSENT=YES+ is only needed for the HTML pages. Like when fetching the captions.
There was a problem hiding this comment.
I though it was only required for the "mixes" nowadays. I'm working on moving the captions to innertube, anyway...
There was a problem hiding this comment.
We could only send the CONSENT+YES cookie if we detect that the path doesn't start with /youtubei.
What do you think?
There was a problem hiding this comment.
We could even restrict more so that it's only sent for /mixes (or the associated innertube endpoint for mixes)
There was a problem hiding this comment.
@SamantazFox without the CONSENT=YES+ cookie EU IP addresses get redirected to the GDPR consent page, so it is definitely still required. AFAIK that also applies to requests to the InnerTube API.
There was a problem hiding this comment.
It doesn't apply to InnerTube API requests, you can test it by yourself, it works fine without this cookie.
It only applies to HTML pages, the InnerTube API is not an HTML page.
|
@SamantazFox I have replicated even more the requests made by a yt app, feel free to review again :D |
|
Just in case: I wanted to add even more sppofing https://github.com/SamantazFox/invidious/tree/yt-api-improvements |
Feel free to discontinue my PR in favor of your work. Do note about the useragents (IOS and android), devicemaker, devicemodel, ios osversion and EDIT: Just looked at the code and it's a very good idea to split things even more :). Good work. |
|
@SamantazFox While we wait for you to finish your improvements, can we at least add the user agent required to solve the issue in #3230? |
|
@unixfox yup, sure. Sorry for the delay :/ |
We won't use your code from https://github.com/SamantazFox/invidious/tree/yt-api-improvements? |
Yes, but later. I don't have much time to work on it atm, so your solution will do in the meantime :) |
|
Deployed on https://test.invidious.io |
unixfox
added
the
need-testing
|
After a few days of testing on yewtu.be. Everything seems fine. Good to merge @SamantazFox? |
|
@unixfox yep, done :) |
This PR tries to replicate all the necessary headers and parameters made by YouTube apps in order to look more like a real YouTube app.
This avoids being classified as "an outdated YouTube app" by YouTube servers like in #3230.
Closes #3230