-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the version in shard.yml
.
@vhuynh3000 can you please take a look at the review from saltycrys? |
If @vhuynh3000 doesn't respond you or @saltycrys can update the code in the pull request and update the |
Right, but there is already v2.28.0, not sure if it's worth to update only to v2.23.1 |
Well v2.28.0 will require again new code changes and at least the job is already done for v2.23.1. v2.23.1 bring new bugs fixed and that's something we welcome very much. |
I guess we should use the liblsquic from https://github.com/iv-org/lsquic-static-alpine. Just opened iv-org/lsquic-static-alpine#1 |
Sure if you create a new tag on https://github.com/iv-org/lsquic-static-alpine I can test on my instance. |
You can get the build from the PR here: https://github.com/iv-org/lsquic-static-alpine/suites/1995406313/artifacts/39816860 |
iv-org/lsquic-static-alpine#1 had a wrong commit for BoringSSL, fixed in iv-org/lsquic-static-alpine#2. Release available here: https://github.com/iv-org/lsquic-static-alpine/releases/tag/v2.23.1 |
Patch is now in testing on my server |
Co-authored-by: saltycrys <[email protected]>
The patch is working fine for 3 days on one of my backend, I guess it's ready. Thanks again @vhuynh3000 |
This reverts commit cb01d0f.
This reverts commit cb01d0f.
No description provided.