Skip to content
This repository was archived by the owner on Jul 21, 2024. It is now read-only.

upgrade to 2.23.1 of lsquic #6

Merged
merged 5 commits into from
Feb 18, 2021
Merged

upgrade to 2.23.1 of lsquic #6

merged 5 commits into from
Feb 18, 2021

Conversation

vhuynh3000
Copy link
Contributor

No description provided.

Copy link
Member

@saltycrys saltycrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the version in shard.yml.

@Perflyst
Copy link
Contributor

Perflyst commented Feb 8, 2021

@vhuynh3000 can you please take a look at the review from saltycrys?

@unixfox
Copy link
Member

unixfox commented Feb 8, 2021

@vhuynh3000 can you please take a look at the review from saltycrys?

If @vhuynh3000 doesn't respond you or @saltycrys can update the code in the pull request and update the shard.yml. It shouldn't be too hard.

@Perflyst
Copy link
Contributor

Perflyst commented Feb 8, 2021

Right, but there is already v2.28.0, not sure if it's worth to update only to v2.23.1

@unixfox
Copy link
Member

unixfox commented Feb 8, 2021

Well v2.28.0 will require again new code changes and at least the job is already done for v2.23.1. v2.23.1 bring new bugs fixed and that's something we welcome very much.

@Perflyst
Copy link
Contributor

Perflyst commented Feb 8, 2021

I guess we should use the liblsquic from https://github.com/iv-org/lsquic-static-alpine. Just opened iv-org/lsquic-static-alpine#1

@unixfox
Copy link
Member

unixfox commented Feb 8, 2021

Sure if you create a new tag on https://github.com/iv-org/lsquic-static-alpine I can test on my instance.

@Perflyst
Copy link
Contributor

Perflyst commented Feb 8, 2021

@saltycrys
Copy link
Member

@Perflyst
Copy link
Contributor

Patch is now in testing on my server

Co-authored-by: saltycrys <[email protected]>
@Perflyst
Copy link
Contributor

The patch is working fine for 3 days on one of my backend, I guess it's ready. Thanks again @vhuynh3000

@Perflyst Perflyst merged commit cb01d0f into iv-org:master Feb 18, 2021
syeopite added a commit to syeopite/lsquic.cr that referenced this pull request Jun 9, 2021
syeopite added a commit to syeopite/lsquic.cr that referenced this pull request Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants