Protect member access, fix tests

ivmartel · Oct 6, 2023 · a076ca7 · a076ca7
1 parent 0fbc05e
commit a076ca7
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 13 deletions.
diff --git a/src/gui/drawLayer.js b/src/gui/drawLayer.js
@@ -93,7 +93,7 @@ export class DrawLayer {
    *
    * @type {object}
    */
-  #drawController = null;
+  #drawController;
 
   /**
    * The plane helper.
@@ -516,7 +516,9 @@ export class DrawLayer {
    *  DeleteCommand has been executed.
    */
   deleteDraw(id, exeCallback) {
-    this.#drawController.deleteDraw(id, this.#fireEvent, exeCallback);
+    if (typeof this.#drawController !== 'undefined') {
+      this.#drawController.deleteDraw(id, this.#fireEvent, exeCallback);
+    }
   }
 
   /**
@@ -526,17 +528,23 @@ export class DrawLayer {
    *  DeleteCommand has been executed.
    */
   deleteDraws(exeCallback) {
-    this.#drawController.deleteDraws(this.#fireEvent, exeCallback);
+    if (typeof this.#drawController !== 'undefined') {
+      this.#drawController.deleteDraws(this.#fireEvent, exeCallback);
+    }
   }
 
   /**
    * Get the total number of draws of this layer
    * (at all positions).
    *
-   * @returns {number} The total number of draws.
+   * @returns {number|undefined} The total number of draws.
    */
   getNumberOfDraws() {
-    return this.#drawController.getNumberOfDraws();
+    let res;
+    if (typeof this.#drawController !== 'undefined') {
+      res = this.#drawController.getNumberOfDraws();
+    }
+    return res;
   }
 
   /**

diff --git a/src/gui/layerGroup.js b/src/gui/layerGroup.js
@@ -731,15 +731,20 @@ export class LayerGroup {
     } else {
       // delete layer draws
       const numberOfDraws = layer.getNumberOfDraws();
-      let count = 0;
-      layer.addEventListener('drawdelete', (_event) => {
-        ++count;
-        // unbind when all draw are deleted
-        if (count === numberOfDraws) {
-          this.#unbindDrawLayer(layer);
-        }
-      });
+      if (typeof numberOfDraws !== 'undefined') {
+        let count = 0;
+        layer.addEventListener('drawdelete', (_event) => {
+          ++count;
+          // unbind when all draw are deleted
+          if (count === numberOfDraws) {
+            this.#unbindDrawLayer(layer);
+          }
+        });
+      }
       layer.deleteDraws();
+      if (typeof numberOfDraws === 'undefined') {
+        this.#unbindDrawLayer(layer);
+      }
       // reset active index
       if (this.#activeDrawLayerIndex === index) {
         this.#activeDrawLayerIndex = undefined;