Fix writing data with vr=xs, fixes #1567

ivmartel · Dec 5, 2023 · f15f2a2 · f15f2a2
1 parent 10f5832
commit f15f2a2
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/src/dicom/dicomWriter.js b/src/dicom/dicomWriter.js
@@ -643,6 +643,13 @@ export class DicomWriter {
           const atValue = [dec1, dec2];
           byteOffset = writer.writeUint16Array(byteOffset, atValue);
         }
+      } else if (element.vr === 'xs') {
+        // TODO would be better to use pixelRepresentation in if
+        if (value instanceof Int16Array) {
+          byteOffset = writer.writeInt16Array(byteOffset, value);
+        } else {
+          byteOffset = writer.writeUint16Array(byteOffset, value);
+        }
       } else {
         logger.warn('Unknown VR: ' + element.vr);
       }

diff --git a/tests/dicom/synthetic-data_explicit.json b/tests/dicom/synthetic-data_explicit.json
@@ -298,7 +298,7 @@
 },
 {
     "name": "lee-08",
-    "description": "Little Endian Explicit test data with mulitple VRs.",
+    "description": "Little Endian Explicit test data with multiple VRs.",
     "tags": {
         "TransferSyntaxUID": "1.2.840.10008.1.2.1",
         "Modality": "MR",
@@ -313,6 +313,7 @@
         "BitsAllocated": 16,
         "BitsStored": 12,
         "HighBit": 11,
+        "SmallestImagePixelValue": 0,
         "PrivateSQ": {
             "value": [
                 {

diff --git a/tests/dicom/synthetic-data_explicit_big-endian.json b/tests/dicom/synthetic-data_explicit_big-endian.json
@@ -298,7 +298,7 @@
 },
 {
     "name": "beb-08",
-    "description": "Big Endian Explicit test data with mulitple VRs.",
+    "description": "Big Endian Explicit test data with multiple VRs.",
     "tags": {
         "TransferSyntaxUID": "1.2.840.10008.1.2.2",
         "Modality": "MR",
@@ -313,6 +313,7 @@
         "BitsAllocated": 16,
         "BitsStored": 12,
         "HighBit": 11,
+        "SmallestImagePixelValue": 0,
         "PrivateSQ": {
             "value": [
                 {

diff --git a/tests/dicom/synthetic-data_implicit.json b/tests/dicom/synthetic-data_implicit.json
@@ -298,7 +298,7 @@
 },
 {
     "name": "lei-08",
-    "description": "Little Endian Implicit test data with mulitple VRs.",
+    "description": "Little Endian Implicit test data with multiple VRs.",
     "tags": {
         "TransferSyntaxUID": "1.2.840.10008.1.2",
         "Modality": "MR",
@@ -313,6 +313,7 @@
         "BitsAllocated": 16,
         "BitsStored": 12,
         "HighBit": 11,
+        "SmallestImagePixelValue": 0,
         "PrivateSQ": {
             "value": [
                 {