Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformer #20823

Closed
1 task done
Shakil7869 opened this issue Jul 25, 2023 · 10 comments
Closed
1 task done

transformer #20823

Shakil7869 opened this issue Jul 25, 2023 · 10 comments
Labels
Stale Sub Task a sub task which is stemming from a ToDo list issue

Comments

@Shakil7869
Copy link

Shakil7869 commented Jul 25, 2023

@Shakil7869
Copy link
Author

@ivy-leaves ivy-leaves added the Sub Task a sub task which is stemming from a ToDo list issue label Jul 25, 2023
@a0m0rajab
Copy link
Contributor

a0m0rajab commented Jul 25, 2023

@Shakil7869 hey, Thank you for your interest in this PR.

I think this comment was meant to be written at this issue: #14945
If that the case you can close: #20821 and #20822

and you needed to mention it here.

@Shakil7869
Copy link
Author

Shakil7869 commented Jul 26, 2023

I have closed #20821 and #20822

@a0m0rajab
Copy link
Contributor

Awesome, thank you for that!

Feel free to write a comment in the main issue as what the docs suggested:

Comment on the ToDo list issue with a reference to this issue like so:
- [ ] #Issue_number

https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues

@Shakil7869
Copy link
Author

Shakil7869 commented Jul 27, 2023

Hi @a0m0rajab , (transformer class) #20823 is missing in stateful layers classes. can you give me guidelines?

@a0m0rajab
Copy link
Contributor

I could not understand your question, though what you need to do right now is to implement the functions in next two locations:

  • ivy/stateful/layers.py
  • ivy_tests/test_ivy/test_stateful/test_layers.py

Side note, I am a contributor like you, though.

@Shakil7869
Copy link
Author

Thanks, for your kind information.
I wanted to tell you that The function which is written for the issue (transformer) is missing in these locations.
So, should I close this issue?

@a0m0rajab
Copy link
Contributor

a0m0rajab commented Jul 27, 2023

Yes it's not implemented, that's the main point of this issue and the whole todo, to implement this function since it's missing and not implemented.
Feel free to read this guides in case if you want to have more details: https://unify.ai/docs/ivy/overview/contributing.html

@ivy-seed ivy-seed added the Stale label Aug 4, 2023
@ivy-seed
Copy link

ivy-seed commented Aug 4, 2023

This issue has been labelled as stale. If you would like to continue working on this issue, then please add another comment or create a PR . If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. For more information please refer to this page in our documentation: https://lets-unify.ai/ivy/contributing/1_the_basics.html#todo-list-issues

@ivy-seed
Copy link

This issue is being closed. As this issue has been stalled with no activity for more than 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Sub Task a sub task which is stemming from a ToDo list issue
Projects
None yet
Development

No branches or pull requests

4 participants