Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat activations #754

Open
7 tasks done
Tracked by #768
, #786 ,  #809
...
djl11 opened this issue Apr 1, 2022 · 6 comments
Open
7 tasks done
Tracked by #768
, #786 ,  #809
...

Reformat activations #754

djl11 opened this issue Apr 1, 2022 · 6 comments
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks

Comments

@djl11
Copy link

djl11 commented Apr 1, 2022 •
edited by ivy-leaves
Loading

As explained in the function reformatting open task, each function in the activations submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:

  1. remove all lambda and direct bindings for backend functions, with each function instead defined using def.
  2. update the function arguments and type hints.
  3. add the correct docstrings
  4. add thorough docstring examples

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

The main file paths where these functions are likely to be added are:

  • .idea/ivy.iml
  • .idea/misc.xml
  • ivy/array/activations.py
  • ivy/container/activations.py
  • ivy/functional/backends/jax/activations.py
  • ivy/functional/backends/numpy/activations.py
  • ivy/functional/backends/tensorflow/activations.py
  • ivy/functional/backends/torch/activations.py
  • ivy/functional/ivy/activations.py
@djl11 djl11 added the ToDo A ToDo list of tasks label Apr 1, 2022
@djl11 djl11 changed the title Add examples to activations docstrings Improve activations docstrings Apr 1, 2022
@djl11 djl11 changed the title Improve activations docstrings Reformat activations Apr 1, 2022
@djl11 djl11 added the Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide label Apr 1, 2022
@kimbochen kimbochen mentioned this issue Apr 2, 2022
Closed
1 task
@AduGyamfi-David AduGyamfi-David mentioned this issue Apr 2, 2022
Closed
@github-actions github-actions bot deleted a comment from RahulBhalley Apr 2, 2022
@github-actions github-actions bot deleted a comment from RahulBhalley Apr 2, 2022
@RahulBhalley RahulBhalley mentioned this issue Apr 2, 2022
Closed
1 task
@github-actions github-actions bot deleted a comment from kimbochen Apr 3, 2022
@github-actions github-actions bot deleted a comment from varsharoshan Apr 4, 2022
@Mia-dev200 Mia-dev200 mentioned this issue Apr 4, 2022
Closed
1 task
@github-actions github-actions bot deleted a comment from Mia-dev200 Apr 4, 2022
@AduGyamfi-David AduGyamfi-David mentioned this issue Apr 7, 2022
Closed
@ivy-llc ivy-llc deleted a comment from hg19939 Apr 7, 2022
@ivy-llc ivy-llc deleted a comment from Erij97 Apr 7, 2022
@AduGyamfi-David AduGyamfi-David mentioned this issue Apr 12, 2022
Closed
@AduGyamfi-David AduGyamfi-David mentioned this issue May 6, 2022
Closed
@ivy-llc ivy-llc deleted a comment from seyunkim0114 May 23, 2022
@ivy-llc ivy-llc deleted a comment from omarmalave May 23, 2022
@ivy-llc ivy-llc deleted a comment from AhmedFakhry47 May 23, 2022
@ivy-llc ivy-llc deleted a comment from b4igiveup May 30, 2022
@frdysf frdysf mentioned this issue May 31, 2022
Closed
1 task
@ivy-llc ivy-llc deleted a comment from gauravrajnajeen Jun 1, 2022
@ivy-llc ivy-llc deleted a comment from dubeyakshat07 Jun 17, 2022
@ivy-llc ivy-llc deleted a comment from owaisorakzai Jun 22, 2022
@ivy-llc ivy-llc deleted a comment from CerberusLatrans Jul 5, 2022
@ivy-llc ivy-llc deleted a comment from JDRanpariya Jul 5, 2022
DrashtySoni added a commit to DrashtySoni/ivy that referenced this issue Jul 26, 2022
@DrashtySoni
Updated ivy-llc#754
1ca2df5 
I have added  ivy-llc#1225, ivy-llc#1267, ivy-llc#784, ivy-llc#1574, ivy-llc#1173, ivy-llc#1467, ivy-llc#1741 under ivy-llc#754 issue.
@DrashtySoni DrashtySoni mentioned this issue Jul 26, 2022
Closed
@shoryak shoryak mentioned this issue Oct 2, 2022
Closed
@ivy-llc ivy-llc deleted a comment from MAyub114 Oct 24, 2022
@ivy-llc ivy-llc deleted a comment from mohamedrekik Oct 29, 2022
@ivy-llc ivy-llc deleted a comment from UsmanNSada Nov 6, 2022
@ivy-llc ivy-llc deleted a comment from dimikave Nov 13, 2022
@ivy-llc ivy-llc deleted a comment from Karim-Akmal Dec 7, 2022
@ivy-llc ivy-llc deleted a comment from Karim-Akmal Dec 22, 2022
@Monsurat-Onabajo Monsurat-Onabajo mentioned this issue Feb 9, 2023
Closed
@ivy-llc ivy-llc deleted a comment from shoryak Feb 9, 2023
Monsurat-Onabajo added a commit to Monsurat-Onabajo/ivy that referenced this issue Feb 11, 2023
@Monsurat-Onabajo
reformatting activations sigmoid ivy-llc#754 ivy-llc#10446
31fb2da
@Monsurat-Onabajo Monsurat-Onabajo mentioned this issue Feb 11, 2023
Merged
Aarsh2001 pushed a commit that referenced this issue Feb 17, 2023
@Monsurat-Onabajo
reformatting activations sigmoid #754 #10446 (#10485)
d044a43 
* reformatting activations sigmoid #754 #10446

* more modification to sigmoid function
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this issue Feb 23, 2023
@Monsurat-Onabajo
reformatting activations sigmoid ivy-llc#754 ivy-llc#10446 (ivy-llc#1…
c1d1394 
…0485)

* reformatting activations sigmoid ivy-llc#754 ivy-llc#10446

* more modification to sigmoid function
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this issue Feb 23, 2023
@Monsurat-Onabajo
reformatting activations sigmoid ivy-llc#754 ivy-llc#10446 (ivy-llc#1…
212adf7 
…0485)

* reformatting activations sigmoid ivy-llc#754 ivy-llc#10446

* more modification to sigmoid function
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this issue Feb 26, 2023
@Monsurat-Onabajo
reformatting activations sigmoid ivy-llc#754 ivy-llc#10446 (ivy-llc#1…
f2bbd95 
…0485)

* reformatting activations sigmoid ivy-llc#754 ivy-llc#10446

* more modification to sigmoid function
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this issue Feb 26, 2023
@Monsurat-Onabajo
reformatting activations sigmoid ivy-llc#754 ivy-llc#10446 (ivy-llc#1…
3f8bdf1 
…0485)

* reformatting activations sigmoid ivy-llc#754 ivy-llc#10446

* more modification to sigmoid function
@wassimchouchen
Copy link

wassimchouchen commented Apr 2, 2023 •
edited
Loading

leaky_relu #6626

@wassimchouchen
Copy link

wassimchouchen commented Apr 2, 2023 •
edited
Loading

sigmoid #5153

@hemrajchoudhary108
Copy link
Contributor

sigmoid #18127

@hemrajchoudhary108 hemrajchoudhary108 mentioned this issue Jul 8, 2023
Merged
@a0m0rajab
Copy link
Contributor

Is there anything needed to be done on this issue? It seems like all functions have a merged PR.

@raslen10 raslen10 mentioned this issue Jul 29, 2023
Closed
@Medo072
Copy link
Contributor

Medo072 commented Aug 22, 2023

#22347

@Se-Gu
Copy link

Se-Gu commented Sep 2, 2023

@ivy-llc ivy-llc deleted a comment from Monsurat-Onabajo Sep 6, 2023
@a0m0rajab a0m0rajab added the hacktoberfest hacktoberfest label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@a0m0rajab @djl11 @sreegandh804 @Se-Gu @Aarsh2001 @wassimchouchen @Medo072 @hemrajchoudhary108