added jax numpy logic_or #10316
Merged
added jax numpy logic_or #10316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
JAX Frontend
kurshakuz
suggested changes
Feb 9, 2023
ivy_tests/test_ivy/test_frontends/test_jax/test_jax_numpy_logic.py
Outdated
Show resolved
Hide resolved
ivy_tests/test_ivy/test_frontends/test_jax/test_jax_numpy_logic.py
Outdated
Show resolved
Hide resolved
|
Your tracked issue #10312 references implementation of logical_or |
Yes, I don't know why it is changed somehow, I will implement it real quick |
Hello, I think now it is implemented, please have a look. |
|
Looking good, can you finally run the test function locally and post the result here? |
Yes, I think it works fine, all tests passed. |
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 23, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 23, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added jax numpy logic_or
Closes #10312