Add numpy.real to Numpy frontend #10483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d1bf8f.
ivy-leaves
added
the
NumPy Frontend
|
Hey @Joboa first of all thanks for contributing ,the PR implementation look's good, though few things require a small fix the PR introduced some lint failures which should be easy to fix could you go through them and fix the lint errors thanks! |
|
@vaatsalya123 , the lint error still persists. I followed the documentation on how to fix it. |
|
Hey @Joboa you need to look through this once more you will understand how to fix the issue basically add spaces at the end of the file: |
|
Yep all look's good thanks! |
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
* Add imag function to Numpy frontend * Fix imag function for Numpy frontend * Add real function to Numpy frontend * Revert "Add real function to Numpy frontend" This reverts commit 9d1bf8f. * Add real function to Numpy frontend * fix real complex numbers function for Numpy frontend
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
* Add imag function to Numpy frontend * Fix imag function for Numpy frontend * Add real function to Numpy frontend * Revert "Add real function to Numpy frontend" This reverts commit 9d1bf8f. * Add real function to Numpy frontend * fix real complex numbers function for Numpy frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10478