isfortran

[shireenchand]

Frontend and test for numpy isfortran

[suvadityamuk]

Hi, @shireenchand 🙂

Could you possibly explain why we should be looking at making use of the a.flags.fnc flag wherein a better alternative exists for using the a.flags.f_contiguous instead?
Also, could you possibly check the linting on the ivy/functional/frontends/numpy/logic/truth_value_testing.py? It seems there are some linting errors on the same.

Thank you for taking the time to make the PR!

[shireenchand]

Hey @suvadityamuk,

The reason why I chose a.flags.fnc is because we get an extra check here on the fact that is it just F_Contiguous and not C_Contiguous as well

[suvadityamuk]

Hey @suvadityamuk,
The reason why I chose a.flags.fnc is because we get an extra check here on the fact that is it just F_Contiguous and not C_Contiguous as well

Right, understood. Thanks for the explanation!

Could you possibly re-check the linting errors? Might I suggest making use of the pre-commit hook to help?

[shireenchand]

Hi @suvadityamuk @V-G-spec, is there a reason why these tests are failing? Like something related to the frontend or do they fail usually?

[suvadityamuk]

Hi, @shireenchand

The previously-occurring linting errors have been fixed, along with the fact that the test you wrote seems to pass.

Thank you for the PR!

@V-G-spec Requesting a final review, actual test run here and linting test run here

[V-G-spec]

Hi, can you revert the changes other than the ones for the function you worked on in the test file?

[shireenchand]

@V-G-spec I corrected those. Can you please check them?

[shireenchand]

Hi @V-G-spec,
Do let me know if there are any other changes that are needed?
Thanks!!

[V-G-spec]

Looks good, and I believe @suvadityamuk verified tests were failing due to some other files