Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add t function, issue 10474 #10588

Merged
merged 7 commits into from
Feb 17, 2023
Merged

feat: add t function, issue 10474 #10588

merged 7 commits into from
Feb 17, 2023

Conversation

ChunchangShao
Copy link
Contributor

@ChunchangShao ChunchangShao commented Feb 15, 2023

Close #10474

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Feb 15, 2023
Copy link
Contributor

@fspyridakos fspyridakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I left a comment for one more addition to the function. Can you also add the test for it? Thanks

@fspyridakos
Copy link
Contributor

Also, I will link this to the corresponding issue, but in future you should do this yourself by adding a comment ‘Close #Issue_number’, as explained here

@fspyridakos
Copy link
Contributor

Looks good, thanks for your contribution! Just made a small formatting change myself

@fspyridakos fspyridakos merged commit dbf2cd1 into ivy-llc:master Feb 17, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 23, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t
3 participants