jax.numpy.convolve frontend function and test. issue #10499 #10603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
JAX Frontend
ivy-leaves
added
the
PyTorch Frontend
fnhirwa
suggested changes
Feb 23, 2023
There was a problem hiding this comment.
Hey @JPGoodale
Thanks for contributing to ivy,
Everything looks great except that the tests are failing for some backends due to precision error during assertion, would you set some tolerance values atol and rtol for the test function?
Thanks and happy coding😊
Thanks for the review, I just added some tolerance values and they're passing all tests my machine. Let me know if I need to fix anything else, thanks! |
fnhirwa
suggested changes
Feb 23, 2023
ivy_tests/test_ivy/test_frontends/test_jax/test_jax_numpy_math.py
Outdated
Show resolved
Hide resolved
fnhirwa
approved these changes
Feb 23, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Co-authored-by: hirwa-nshuti <[email protected]>
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Co-authored-by: hirwa-nshuti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10499.