-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix frontends.torch.{h,v,d}split #10810
fix frontends.torch.{h,v,d}split #10810
Conversation
Good catch! @xoiga123, left two comments, after that we should be good to merge:) |
ivy/functional/frontends/torch/indexing_slicing_joining_mutating_ops.py
Outdated
Show resolved
Hide resolved
ivy/functional/frontends/torch/indexing_slicing_joining_mutating_ops.py
Outdated
Show resolved
Hide resolved
if isinstance(indices_or_sections, (list, tuple)): | ||
pass | ||
elif indices and not sections: | ||
if not isinstance(indices_or_sections, (list, tuple, int)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not ivy.exists(indices_or_sections):
is probably even better, I updated the previous comment but was too late it seems, sorry for that, we can merge after this little tweak:)
lgtm, thanks for your contribution to ivy:) |
…split fix frontends.torch.{h,v,d}split
…split fix frontends.torch.{h,v,d}split
Apparently, unlike what the docs state:
these calls are all valid: