Conv2D #10505

[kaushal07wick]

New PR for the Conv2D support in raw_ops and raw_ops test file
It passes all the tests.
But it doesn't has explicit_padding support.

[Infrared1029]

Hi @kaushal07wick! Thanks a lot for taking the time to contribute to ivy, since this is a frontend function, it has to adhere to the true tf.raw_ops.Conv2D function signature, we can not exclude the explicit_padding argument (even if we end up not using it in the function). Saying that, explicit padding is not the type of argument to be ignored as it contributes to the final output of the function, unlike other arguments such as use_cudnn_gpu which still must be included (to adhere to the true definition of the function) but is never used as it does not contribute to the "mathematics" of Conv2D. Also, make sure to remove commented code.

[kaushal07wick]

Hi @kaushal07wick! Thanks a lot for taking the time to contribute to ivy, since this is a frontend function, it has to adhere to the true tf.raw_ops.Conv2D function signature, we can not exclude the explicit_padding argument (even if we end up not using it in the function). Saying that, explicit padding is not the type of argument to be ignored as it contributes to the final output of the function, unlike other arguments such as use_cudnn_gpu which still must be included (to adhere to the true definition of the function) but is never used as it does not contribute to the "mathematics" of Conv2D. Also, make sure to remove commented code.

Hi @Infrared1029 , the commented code is of explicit_paddings, bu tit was giving some issues, so I tested it without it and created a PR after successful tests.

I will work on the explicit_padding support and push it very soon.
It would be great to get some help from you.

[Infrared1029]

Hi @kaushal07wick! Thanks a lot for taking the time to contribute to ivy, since this is a frontend function, it has to adhere to the true tf.raw_ops.Conv2D function signature, we can not exclude the explicit_padding argument (even if we end up not using it in the function). Saying that, explicit padding is not the type of argument to be ignored as it contributes to the final output of the function, unlike other arguments such as use_cudnn_gpu which still must be included (to adhere to the true definition of the function) but is never used as it does not contribute to the "mathematics" of Conv2D. Also, make sure to remove commented code.

Hi @Infrared1029 , the commented code is of explicit_paddings, bu tit was giving some issues, so I tested it without it and created a PR after successful tests.

I will work on the explicit_padding support and push it very soon. It would be great to get some help from you.

Good luck! sure just ping me if you need any help.