Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conv2D #10505 #11991

Closed
wants to merge 10,000 commits into from
Closed

Conv2D #10505 #11991

wants to merge 10,000 commits into from

Conversation

kaushal07wick
Copy link
Contributor

No description provided.

sherry30 and others added 8 commits March 8, 2023 20:46
@sherry30
adding lanczos3 and lanczos5 mode in interpolate
e382fd8
@AnnaTz
added mitchellcubic and gaussian moded to ivy.interpolate
b7f33b2
@CatB1t
Add apply_flags method for test flags (#11954)
4cf3d5b 
- Add TestFlags class base, add `apply_flags` method to handle applying test flags to arguments.
- Refactored and update redundant code after adding the `apply_flags` method.
- Added missing `on_device` parameter to `test_frontend_method`.
- Updated `create_args_kwargs` to make use of the `on_device` parameter.
@AnnaTz
added tf.image.resize
6659f80
@CatB1t
Update test_method init flags to not include container flags.
0ea8052
@CatB1t
refactor create_args_kwargs ignored returns.
b8ce499
@AnnaTz
test interpolate for True/False antialias
1e4c273
@kaushal07wick
COnv2D_for_raw_ops
a853d24
@kaushal07wick kaushal07wick mentioned this pull request Mar 8, 2023
Closed
@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Mar 8, 2023
@kaushal07wick
Copy link
Contributor Author

hey @sherry30, I have problem with explicit_paddings argument. Any help would be appreciated. Thanks

@kaushal07wick
Copy link
Contributor Author

while running the test for jax, it passes but for numpy it shows this

>       array = np.asarray(DummyArray(interface, base=x))
E       ValueError: negative dimensions are not allowed
E       Falsifying example: test_tensorflow_Conv2D(
E           x_f_d_df=(['float16'], array([[[[0.686 ],
E                     [0.558 ],

@kaushal07wick
Copy link
Contributor Author

this is the error i get while running the tensorflow and jax tests

FAILED [  0%]2023-03-08 19:37:29.140328: W tensorflow/core/framework/op_kernel.cc:1745] OP_REQUIRES failed at mkl_conv_ops.h:439 : INVALID_ARGUMENT: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1]
2023-03-08 19:37:29.645817: W tensorflow/core/framework/op_kernel.cc:1745] OP_REQUIRES failed at mkl_conv_ops.h:439 : INVALID_ARGUMENT: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1]
2023-03-08 19:37:29.820001: W tensorflow/core/framework/op_kernel.cc:1745] OP_REQUIRES failed at mkl_conv_ops.h:439 : INVALID_ARGUMENT: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1]
2023-03-08 19:37:29.995636: W tensorflow/core/framework/op_kernel.cc:1745] OP_REQUIRES failed at mkl_conv_ops.h:439 : INVALID_ARGUMENT: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1]
2023-03-08 19:37:31.184401: W tensorflow/core/framework/op_kernel.cc:1745] OP_REQUIRES failed at mkl_conv_ops.h:439 : INVALID_ARGUMENT: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1]
 e = _NotOkStatusException(), name = None

    def raise_from_not_ok_status(e, name):
      e.message += (" name: " + name if name is not None else "")
>     raise core._status_to_exception(e) from None  # pylint: disable=protected-access
E     tensorflow.python.framework.errors_impl.InvalidArgumentError: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1] [Op:Conv2D]
E     Falsifying example: test_tensorflow_Conv2D(
E         x_f_d_df=(['float32'], array([[[[0.5       ],
E                   [0.5       ],e = _NotOkStatusException(), name = None

    def raise_from_not_ok_status(e, name):
      e.message += (" name: " + name if name is not None else "")
>     raise core._status_to_exception(e) from None  # pylint: disable=protected-access
E     tensorflow.python.framework.errors_impl.InvalidArgumentError: Computed output size would be negative: -1 [input_size: 3, effective_filter_size: 5, stride: 1] [Op:Conv2D]
E     Falsifying example: test_tensorflow_Conv2D(
E         x_f_d_df=(['float32'], array([[[[0.5       ],
E                   [0.5       ],

Dhruv2012 and others added 16 commits March 9, 2023 01:40
@Dhruv2012 @zaeemansari70
triplet_margin_loss (#11544)
99de718 
Co-authored-by: zaeemansari70 <[email protected]>
@MuhammadSaeedBatikh
Merge pull request #11940 from joshiayush/DefaultDevice_exit
bfb44de 
Reformat `DefaultDevice.__exit__()` to include type hints for `exc_type`, `exc_val`, and `exc_tb`
@xingyu-long @zaeemansari70
Add logspace for jax frontend and its test (#11935)
d5a7eac 
Co-authored-by: zaeemansari70 <[email protected]>
@xoiga123
fix promote_types_of_inputs: if one of the inputs is a scalar, make s…
93964b5 
…ure it will have the same device as the other one when converted to [native]array regardless of default device (#11928)
@xoiga123
add instance frontends.torch.tensor_split and test (#11956)
6dd641a
@soma2000-lang @vedpatwardhan
Throwing warning if frameworks get imported on importing ivy (#11784)
b715ecf 
Co-authored-by: Ved Patwardhan <[email protected]>
@ZiadAmerr @sagewhocodes @Dsantra92
Reducing space of the CPU docker image (#11807)
6bf58a3 
* Install CPU only version of torch, as there is no need to install cuDNN and CUDA

* Install CPU only version of torch, as there is no need to install cuDNN and CUDA

* Install CPU only version of torch

There is no need to install cuDNN and CUDA.

* Update Dockerfile

* Updated torch installation to install CPU only

* Updated torch installation to install CPU only

* Install CPU-only torch

* Updated torch installation

Install CPU-only wheel

* Pinned torch to latest

* Unpinned versions of torch CPU

* Unpinned versions of torch CPU

* Updated Dockerfile

Co-authored-by: Deeptendu Santra <[email protected]>

* Remove nvidia-ml-py library

* Delete requirements_cpu.txt

* Added `optional_cpu.txt`

* Updated `optional_cpu.txt`'s comments

* Delete optional_cpu.txt

* Install only cpu speific variant libraries

* Minor change in Dockerfile

* Reverted back

* Defaulted to CPU-based libraries

* test with optional_gpu

* remove optional_gpu

---------

Co-authored-by: Abhimanyu <[email protected]>
Co-authored-by: Deeptendu Santra <[email protected]>
Co-authored-by: Deeptendu Santra <[email protected]>
@leacornelio
Implemented front jax numpy subtract (#11918)
b6364e7 
Co-authored-by: Lea Cornelio <[email protected]>
@RheagalFire
pushing again (#11592)
78fa0e9 
Co-authored-by: WilliamHirst [email protected]
@chetna-mittal
Updated docstring (#11709)
6e11ce4
@fspyridakos
Updated Applied dockerfile to build unifyai/ivy:latest as base
f05252e
@vedpatwardhan
Update docs.yml
ef9bdf4
@vaatsalya123
Update compiler
ea5450c
@vedpatwardhan
Update docs.yml
9d531cc
@vedpatwardhan
Create docs-cleanup.yml
b41a80b
@vedpatwardhan
Update docs-cleanup.yml
ebdfd2e
@kaushal07wick kaushal07wick requested review from sherry30 and removed request for sherry30 March 18, 2023 07:51
@kaushal07wick
Copy link
Contributor Author

hi @sherry30 , this is what its generating, I am not able to understand to where make changes, where is the x_and_filters function description, maybe from that i can understand something

Screenshot from 2023-03-18 07-49-08

@kaushal07wick kaushal07wick requested review from sherry30 and removed request for sherry30 March 18, 2023 18:23
@zaeemansari70
Copy link
Contributor

Hi @kaushal07wick , there was a force-push recently due to which your PR shows many unwanted changes, please take a look at this announcement, I hope this resolves it 🙂
https://discordapp.com/channels/799879767196958751/983684937712558080/1080080255387189318

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Mar 23, 2023
@kaushal07wick kaushal07wick closed this by deleting the head repository Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 Awaiting requested review from sherry30

Assignees

@sherry30 sherry30

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.