Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple Raw Ops to TensorFlow frontend #12100

Merged
merged 11 commits into from
Mar 17, 2023

Conversation

KevinUnadkat
Copy link
Contributor

@KevinUnadkat KevinUnadkat commented Mar 9, 2023

Closes #11629
Closes #11633
Closes #11635
Closes #12548
Closes #12555

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Mar 9, 2023
@KevinUnadkat
Copy link
Contributor Author

KevinUnadkat commented Mar 10, 2023

@WilliamHirst can u pls check the error I'm getting in ivy/functional/frontends/tensorflow/raw_ops.py file from line 622 to line 625
I can understand what does it mean

@WilliamHirst
Copy link
Contributor

Hi Kevin,
There is a formatting error. Your functions have breached the maximum line limit (88).

@WilliamHirst
Copy link
Contributor

Hi Kevin,
Two of your lines (628 and 630) are still breaching the maximum number of characters. They are 93 and 92 characters respectively, and should be less that 88. For some reason the error log says this error is on lines 665 and 667, but this is wrong. It is on 628 and 630.

Let me know when this is fixed! 👍

@KevinUnadkat
Copy link
Contributor Author

KevinUnadkat commented Mar 14, 2023

Hi Kevin, Two of your lines (628 and 630) are still breaching the maximum number of characters. They are 93 and 92 characters respectively, and should be less that 88. For some reason the error log says this error is on lines 665 and 667, but this is wrong. It is on 628 and 630.

Let me know when this is fixed! 👍

hy @WilliamHirst , I fixed the error

@WilliamHirst WilliamHirst merged commit 73c46f5 into ivy-llc:master Mar 17, 2023
Ishticode added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real DebugGradientIdentity AccumulateNV2 Complex CumulativeLogsumexp
3 participants