Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextafter #13076

Merged
merged 3 commits into from
Apr 15, 2023
Merged

nextafter #13076

merged 3 commits into from
Apr 15, 2023

Conversation

shireenchand
Copy link
Contributor

Added frontend and test for numpy nextafter

@shireenchand
Copy link
Contributor Author

#13077

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 24, 2023
@aditya-hari
Copy link
Contributor

Hey, unfortunately the tests are failing

RuntimeError: "nextafter_cpu" not implemented for 'Half'

Just need to handle that

@ivy-seed ivy-seed assigned zhumakhan and unassigned aditya-hari Apr 2, 2023
@ivy-seed ivy-seed added the Stale label Apr 6, 2023
@ivy-seed
Copy link

ivy-seed commented Apr 6, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed closed this Apr 13, 2023
@ivy-seed
Copy link

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

@zhumakhan zhumakhan reopened this Apr 13, 2023
@zhumakhan
Copy link
Contributor

Hi, thanks for you PR, could you please remove unused imports. Rest seems good to me. There is error related to torch backend's nextafter with float16, but that should be a separate issue.

@shireenchand
Copy link
Contributor Author

Hi @zhumakhan, I have removed the unused imports. Please do let me know if there are any other issues!

@zhumakhan zhumakhan merged commit 34a93b6 into ivy-llc:master Apr 15, 2023
@shireenchand shireenchand deleted the pr7 branch April 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants