Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12400 Added conj to ivy frontend #13248

Merged
merged 7 commits into from
Apr 14, 2023
Merged

#12400 Added conj to ivy frontend #13248

merged 7 commits into from
Apr 14, 2023

Conversation

RakshitKumar04
Copy link
Contributor

No description provided.

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 27, 2023
@RakshitKumar04
Copy link
Contributor Author

Close #12400

@RakshitKumar04
Copy link
Contributor Author

Hey, @danielmunioz please review my PR.

@RakshitKumar04
Copy link
Contributor Author

Hey, @danielmunioz can you please take a look at the PR

@danielmunioz
Copy link
Contributor

danielmunioz commented Mar 30, 2023 •
edited
Loading

Hey @RakshitKumar04! Thanks for the contribution!, the tests for your function seem to be failing, locally at least, could you please take a look at that? as well as updating your branch please?, Also the function seems to be missing the out parameter, the frontend function itself should resemble the original framework function as much as possible. Also, there seem to be some lint issues particularly on the test, could you take please a loot at those as well?

@ivy-seed ivy-seed added the Stale label Apr 4, 2023
@ivy-seed
Copy link

ivy-seed commented Apr 4, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@RakshitKumar04
Copy link
Contributor Author

.

@RakshitKumar04 RakshitKumar04 force-pushed the conj branch 2 times, most recently from 88232b5 to 9c77366 Compare April 8, 2023 22:09
@RakshitKumar04
Copy link
Contributor Author

Hey @danielmunioz can you please guide me on how to resolve this error
E hypothesis.errors.InvalidArgument: test_numpy_conj() got an unexpected keyword argument 'dtype_and_x', from dtype_and_x=dtype_and_values(available_dtypes=get_dtypes(kind='real_and_complex')) in @given

@RakshitKumar04
Copy link
Contributor Author

Hey, @danielmunioz corrected the above errors. Can you please review it.

@danielmunioz
Copy link
Contributor

danielmunioz commented Apr 14, 2023 •
edited
Loading

Hey @RakshitKumar04, Looks good to me! Glad you managed to fix the issues! 🎉
Thanks for the contribution :)

@danielmunioz danielmunioz merged commit 3521d99 into ivy-llc:master Apr 14, 2023
@RakshitKumar04 RakshitKumar04 deleted the conj branch June 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielmunioz danielmunioz

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RakshitKumar04 @danielmunioz @ivy-seed @ivy-leaves