Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue #13380

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fixed issue #13380

merged 2 commits into from
Mar 31, 2023

Conversation

rajshukla1102
Copy link
Contributor

Close #10421

@rajshukla1102 rajshukla1102 mentioned this pull request Mar 29, 2023
Closed
@rajshukla1102
Copy link
Contributor Author

@hirwa-nshuti look into once. Thankyou!

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 29, 2023
Dsantra92
Dsantra92 suggested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@Dsantra92 Dsantra92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numpy converts each value to int64. You might want to cast each value in the tuple to int64. It should fix the current tests.

rajshukla1102
rajshukla1102 commented Mar 29, 2023
View reviewed changes
Copy link
Contributor Author

@rajshukla1102 rajshukla1102 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dsantra92 I have made the changes. please look into it once.

@ivy-seed ivy-seed assigned zhumakhan and unassigned Dsantra92 Mar 30, 2023
@zhumakhan
Copy link
Contributor

Hi, thanks for you contribution!
Could you please also add support for 'C' and 'F' (fortran) orders? Everything else seems good to me!
Thanks

@rajshukla1102
Copy link
Contributor Author

@zhumakhan Thanks for the review but currently I think ivy is not supporting orders. It is the reason I didn't add support. Thank you!

@zhumakhan
Copy link
Contributor

Yeah, you are right.
Lets merge then!

@zhumakhan zhumakhan merged commit 11422d0 into ivy-llc:master Mar 31, 2023
@rajshukla1102 rajshukla1102 deleted the unravelissue branch March 31, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dsantra92 Dsantra92 Dsantra92 requested changes

Assignees

@zhumakhan zhumakhan

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unravel_index
4 participants
@rajshukla1102 @zhumakhan @Dsantra92 @ivy-leaves