Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add torch.norm function #14941

Merged
merged 1 commit into from
May 5, 2023
Merged

Add torch.norm function #14941

merged 1 commit into from
May 5, 2023

Conversation

paulaehab
Copy link
Contributor

Close #14816

@paulaehab paulaehab requested a review from AnnaTz May 5, 2023 12:51
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label May 5, 2023
AnnaTz
AnnaTz suggested changes May 5, 2023
View reviewed changes
ivy_tests/test_ivy/test_frontends/test_torch/test_reduction_ops.py
test_flags=test_flags,
fn_tree=fn_tree,
on_device=on_device,
rtol=1e-01,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only thing is the rtol 10% is very high. Isn't the test passing without this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnaTz
yes because when I change it it say the ground truth between frame works not equal but when I test it it give the same result I don't know why

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I guess there is some inconsistency between torch and our ivy functions. I don't think this can be fixed in this PR. I'd say you can merge this now.

@paulaehab paulaehab requested a review from AnnaTz May 5, 2023 13:09
@paulaehab paulaehab merged commit 64b3405 into ivy-llc:master May 5, 2023
@paulaehab paulaehab deleted the Add-torch.norm branch May 5, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

Assignees

@CatB1t CatB1t

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch.norm
4 participants
@paulaehab @AnnaTz @CatB1t @ivy-leaves