Added AvgPool1D + stateful test
#15350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #15348 |
|
@zaeemansari70 do you mind reviewing this PR ? The tests are passing on my end |
MahmoudAshraf97
suggested changes
May 25, 2023
ivy/stateful/layers.py
Outdated
Comment on lines
1557
to
1559
| device=None, | ||
| v=None, | ||
| dtype=None, |
There was a problem hiding this comment.
why are these arguments needed? the layer has no variables to initialize to to place on devices
There was a problem hiding this comment.
They are needed in the __init__ method of the Module class. I followed the convention used in the rest of the layers
MahmoudAshraf97
suggested changes
Jun 5, 2023
The implementation is consistent with the rest of the layers in the module, even |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.