Add numpy.histogram frontend #16669
Add numpy.histogram frontend #16669
Conversation
ivy-leaves
added
the
NumPy Frontend
RohitSgh
changed the title
| weights=None, | ||
| density=None, | ||
| *, | ||
| out=None, |
There was a problem hiding this comment.
not sure if I overlooked anything, but I don't think the numpy histogram has out and dtype argument?
ref: https://numpy.org/doc/stable/reference/generated/numpy.histogram.html
This comment was marked as outdated.
This comment was marked as outdated.
|
Can you please help me in resolving the issue, @juliagsy? |
|
Tried to solve on own and things getting worse 😅 |
|
Hey @RohitSgh ! So sorry, seems like there might be some issue with the ci earlier, would you mind pushing a commit of some dummy changes so that the ci reruns automatically? Apologies for any inconvenience and thanks a lot! |
| density=None, | ||
| weights=None, | ||
| ): | ||
| [x.dtype for x in [a, weights]] |
There was a problem hiding this comment.
as the ivy histogram function are able to handle the default values from numpy, could you please try to reduce additional codes here?
unless there are necessary for the tests to pass, please try to minimise additional code!
| if weights is None: | ||
| weights = ivy.ones_like(a) | ||
| if range is None: | ||
| range = (a.min(), a.max()) |
There was a problem hiding this comment.
one necessary condition might be if density is None, we set it to False
|
Hi @juliagsy. I will work on some different issue. Therefore, Closing PR. Thanks! |
add_frontend_checklist
closes #16539