Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy-frontend/remainder #17588

Merged
merged 3 commits into from
Jun 27, 2023
Merged

numpy-frontend/remainder #17588

merged 3 commits into from
Jun 27, 2023

Conversation

SharmaAkshat007
Copy link
Contributor

  • Implemented frontend function for numpy remainder
  • Implemented test for this function
  • Closes remainder #17587

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jun 22, 2023
@SharmaAkshat007
Copy link
Contributor Author

@AnnaTz Hey, can you help me with these failing checks?

@SharmaAkshat007
Copy link
Contributor Author

@AnnaTz @Aarsh2001 @zaeemansari70 Can you review this PR?

AnnaTz
AnnaTz approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@AnnaTz AnnaTz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AnnaTz AnnaTz merged commit cc8f2e1 into ivy-llc:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaTz AnnaTz AnnaTz approved these changes

Assignees

@AnnaTz AnnaTz

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remainder
3 participants
@SharmaAkshat007 @AnnaTz @ivy-leaves