Added mathematical function jax.numpy.imag #18982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
JAX Frontend
hmahmood24
requested changes
Jul 8, 2023
There was a problem hiding this comment.
Hey @moezAhmad, requested some changes for you to look into. Do request a re-review once done. Thanks! :)
| on_device=on_device, | ||
| rtol=1e-2, | ||
| atol=1e-2, | ||
| input=x[0], |
There was a problem hiding this comment.
The input here should instead be val
Comment on lines
2545
to
2546
| rtol=1e-2, | ||
| atol=1e-2, |
There was a problem hiding this comment.
Are the tests not passing with a low tolerance value? Somewhere around 1e-4? 1e-2 seems to be too high of a tolerance value
Comment on lines
2518
to
2520
| # imag | ||
|
|
||
|
|
There was a problem hiding this comment.
Pretty sure these are lint/formatting issues. Can you kindly resolve these? :) We recommend using pre-commit to automatically format your PRs every time you commit. Thanks
|
@hmahmood24 Thank you for reviewing my pr. I have implemented changes as you requested. |
hmahmood24
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #18981