Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19402. Added Einsum function to rawops #19405

Merged
merged 2 commits into from
Jul 31, 2023
Merged

#19402. Added Einsum function to rawops #19405

merged 2 commits into from
Jul 31, 2023

Conversation

janchilling
Copy link
Contributor

Close #19402

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Jul 14, 2023
@theRealBird
Copy link
Contributor

Hi @janchilling,
Thank you for your contribution to Ivy, any information about the unsupported data-types which needs to be added here?

@janchilling
Copy link
Contributor Author

Hi @janchilling, Thank you for your contribution to Ivy, any information about the unsupported data-types which needs to be added here?

Thank you for checking the PR. Since this is a rawops implementation, which refers to the Einsum in general functions so isn't the information about the unsupported datatypes be included in the general functions rather at rawops?

@janchilling
Copy link
Contributor Author

janchilling commented Jul 18, 2023 •
edited
Loading

@theRealBird Would appreciate if I can get a reply. Thank you.

@janchilling
Copy link
Contributor Author

@theRealBird Can you please provide an review or request a change please 😄

@theRealBird
Copy link
Contributor

Hi @janchilling, thank you so much for your patience. I really appreciate it.

Explicitly mentioning supported dtypes seems to be the norm for other raw_ops implementations as well, you are right, ideally the information should go in the frontend implementation, but currently that is not present as you might have also seen. I think it would be best to include it here just as a fail-safe.

Thanks!

theRealBird
theRealBird suggested changes Jul 23, 2023
View reviewed changes
ivy/functional/frontends/tensorflow/raw_ops.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please aslo resolve the merge conflicts. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theRealBird I resolved the merge conflicts and added the supported data types for the function. Please update me if I have to make anymore changes.

@janchilling janchilling requested a review from theRealBird July 26, 2023 12:24
@janchilling
Copy link
Contributor Author

@theRealBird Can I get an update please, Thank you!

theRealBird
theRealBird approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@theRealBird theRealBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janchilling

@theRealBird
Copy link
Contributor

Hi @janchilling,
Thank you for your patience and making the changes!

@theRealBird theRealBird merged commit dc55d34 into ivy-llc:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealBird theRealBird theRealBird approved these changes

Assignees

@theRealBird theRealBird

Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Einsum
3 participants
@janchilling @theRealBird @ivy-leaves