Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added any to paddle math #19553

Merged
merged 18 commits into from
Jul 31, 2023
Merged

added any to paddle math #19553

merged 18 commits into from
Jul 31, 2023

Conversation

sroycho4
Copy link
Contributor

close #19552

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 18, 2023
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sroycho4, thanks for looking into this! 😄
Added comments in the code, feel free to request a review after making the changes.
Hope this helps - https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/any_en.html
Thanks! 😄

@@ -384,3 +384,8 @@ def lerp(x, y, weight, name=None):
@to_ivy_arrays_and_back
def rsqrt(x, name=None):
return 1 / ivy.sqrt(x)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing supported dtypes

ivy/functional/frontends/paddle/tensor/math.py Outdated Show resolved Hide resolved
@sroycho4
Copy link
Contributor Author

@rishabgit whoops, don't know how it got altered. Fixed them!

@sroycho4 sroycho4 requested a review from rishabgit July 24, 2023 07:43
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing supported dtypes 😅
Feel free to request a re-review!

@sroycho4
Copy link
Contributor Author

@rishabgit done!

@rishabgit
Copy link
Contributor

Thanks for the changes, they look great!

@rishabgit rishabgit merged commit 9f6b87c into ivy-llc:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

any
3 participants