Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flatten method to the Paddle frontend #22587

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Added flatten method to the Paddle frontend #22587

merged 1 commit into from
Dec 25, 2023

Conversation

he11owthere
Copy link
Contributor

closes #22582

image

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@he11owthere
Copy link
Contributor Author

Please remove "bfloat16" from with_supported_dtypes decorator before running the tests until the issue with ivy.Array.repr method has been fixed as mentioned by Ved in #21447. Thank you! 🙂

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 25, 2023
@aparajith21
Copy link
Contributor

Hi, could you please comment add_frontend_checklist, go over the items there, and check if they're all good and go over any test failures locally. Please request review after that and I will check or let me know if there's any help needed meanwhile!

@he11owthere
Copy link
Contributor Author

he11owthere commented Aug 29, 2023

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • ❌: The function/method definition is not missing any of the original arguments.
    • ❌: In case the function/method to be implemented is an alias of an existing function/method:
        • ❌: It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • ❌: The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • ❌: The naming of the function/method and its arguments exactly matches the original.
    • ❌: No defined argument is being ignored in the function/method's implementation.
    • ❌: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • ❌: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • ❌: In case a frontend function is being added:
        • ❌: It is a composition of ivy functions.
        • ❌: In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • ❌: @to_ivy_arrays_and_back has been added to the function.
    • ❌: In case a frontend method is being added:
        • ❌: It is composed of existing frontend functions or methods.
        • ❌: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • ❌: @to_ivy_arrays_and_back has been added to the method.
          • ❌: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • ❌: The function/method's test has been added (except in the alias case mentioned in <2>):
        • ❌: All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • ❌: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • ❌: The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • ❌: The PR is not introducing any test failures.
        • ❌: The lint checks are passing.
        • ❌: The implemented test is passing for all backends.
    • ❌: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • ❌: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • ❌: The PR only contains changes relevant to the addressed subtask.

@aparajith21
Copy link
Contributor

Hey, seems there are some failures on the CI. Could you please check these locally and see what shows up there. Further, it would be great if you could check off the items in the front end checklist and confirm everything has been completed properly before requesting review. Same applies for the other PR! Thanks for taking the time and contributing!

@he11owthere
Copy link
Contributor Author

Hi @aparajith21, all tests are passing locally, and I've thoroughly reviewed everything. This is my first time encountering this process after contributing for a while. I've tried to check for any inconsistencies and test checks, cannot seem to find what's wrong. Could you please mention if there's a specific problem to this PR, I'll try to fix it.

image

@@ -96,6 +96,28 @@ def reshape(self, *args, shape=None):
def dim(self):
return self.ivy_array.ndim

@with_supported_dtypes(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue may be related to this, and you may want to change this to unsupported and check if tests pass on the CI

@NripeshN NripeshN merged commit 8959bc8 into ivy-llc:main Dec 25, 2023
133 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatten
4 participants