Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added RawOps operation Conj to Tensorflow Frontend #26420

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: Added RawOps operation Conj to Tensorflow Frontend #26420

merged 3 commits into from
Oct 5, 2023

Conversation

Debdeepghosal
Copy link
Contributor

PR Description

This PR adds Conj Operation to TensorFlow frontend

Close #26416

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@Debdeepghosal Debdeepghosal changed the title Added RawOps operation Conj to Tensorflow Frontend feat: Added RawOps operation Conj to Tensorflow Frontend Oct 1, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Oct 1, 2023
@Debdeepghosal
Copy link
Contributor Author

Debdeepghosal commented Oct 2, 2023

@mohame54 Kindly check my PR

@mohame54
Copy link
Contributor

mohame54 commented Oct 4, 2023

Hi @Debdeepghosal thanks for your contribution, but I have a minor question:
Why did change the parameter name in tf.math.conj frontend function as the frontend guide states that the frontend function signature should be the same as the framework function
image

@mohame54
Copy link
Contributor

mohame54 commented Oct 4, 2023

so would you kindly modify the function signature to the old like the function in the image above ?

@Debdeepghosal
Copy link
Contributor Author

Okay I will do that

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@Debdeepghosal
Copy link
Contributor Author

@mohame54 Can you check it now

@mohame54
Copy link
Contributor

mohame54 commented Oct 5, 2023

@Debdeepghosal looks good to me.

@mohame54 mohame54 merged commit 09fcb0f into ivy-llc:main Oct 5, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conj
3 participants