-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ivy branch #26768
Ivy branch #26768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
Hi @RaniaMansour, thank you for your interest in contributing to Ivy! Could you first link your issue to the corresponding To-Do list as explained in the open tasks section of our docs ? Thanks! |
Hello, Does linking the issue is done as follows? Through adding a comment
_[ ] # 26768 in Add RawOps Operations for TensorFlow frontend
<#1565 (comment)> open tasks.
…On Mon, 9 Oct 2023 at 00:17, nassimberrada ***@***.***> wrote:
Hi @RaniaMansour <https://github.com/RaniaMansour>, thank you for your
interest in contributing to Ivy! Could you first link your issue to the
corresponding To-Do list as explained in the open tasks
<https://unify.ai/docs/ivy/overview/contributing/open_tasks.html> section
of our docs ? Thanks!
—
Reply to this email directly, view it on GitHub
<#26768 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUCURFLLX37KGEVDRSR26JLX6MJ6XAVCNFSM6AAAAAA5XQDFIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGE3DIMBVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi, yes you typically need to add the issue you've created as a comment to the To-Do list, I just assigned your issue to the function in the interest of time. Regarding your implementation it looks mostly good, I think there might be a duplication of the test function, I assume that wasn't intended so maybe you could remove the one below the test function for Zeta for e.g. Also, please make sure the tests pass locally as the intelligent tests are currently unreliable and in the process of being fixed. Let me know when you've done so and would like another review. Thanks! |
Closing Stale PR |
PR Description
feat: Added tensorflow frontend function ScatterNd in Raw_ops and test_raw_ops
Related Issue
Close #26767
Checklist
Socials