Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy branch #26768

Closed
wants to merge 3 commits into from
Closed

Ivy branch #26768

wants to merge 3 commits into from

Conversation

RaniaMansour
Copy link

@RaniaMansour RaniaMansour commented Oct 8, 2023

PR Description

feat: Added tensorflow frontend function ScatterNd in Raw_ops and test_raw_ops

Related Issue

Close #26767

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@nassimberrada
Copy link
Contributor

Hi @RaniaMansour, thank you for your interest in contributing to Ivy! Could you first link your issue to the corresponding To-Do list as explained in the open tasks section of our docs ? Thanks!

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Oct 9, 2023
@RaniaMansour
Copy link
Author

RaniaMansour commented Oct 9, 2023 via email

@nassimberrada
Copy link
Contributor

Hi, yes you typically need to add the issue you've created as a comment to the To-Do list, I just assigned your issue to the function in the interest of time. Regarding your implementation it looks mostly good, I think there might be a duplication of the test function, I assume that wasn't intended so maybe you could remove the one below the test function for Zeta for e.g. Also, please make sure the tests pass locally as the intelligent tests are currently unreliable and in the process of being fixed. Let me know when you've done so and would like another review. Thanks!

@nassimberrada
Copy link
Contributor

Closing Stale PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScatterNd
3 participants