feat: add kaiser_window to pytorch frontend #26788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ivy-leaves
added
the
PyTorch Frontend
Sam-Armstrong
requested changes
Oct 10, 2023
There was a problem hiding this comment.
@Mainakdeb looks good, please could you address the comment I left :)
Co-authored-by: Sam Armstrong <[email protected]>
Thanks @Sam-Armstrong, updated 🙂 |
|
@Mainakdeb please could you also add it to the ivy method call within the frontend function and the test? 🙂 |
|
@Sam-Armstrong , many thanks for the pointers🙂, updated test ( |
Sam-Armstrong
approved these changes
Oct 13, 2023
p1utoze
pushed a commit
to p1utoze/ivy
that referenced
this pull request
Oct 13, 2023
Co-authored-by: Sam Armstrong <[email protected]>
p1utoze
pushed a commit
to p1utoze/ivy
that referenced
this pull request
Oct 13, 2023
Co-authored-by: Sam Armstrong <[email protected]>
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
Co-authored-by: Sam Armstrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
add kaiser_window to pytorch frontend
Related Issue
Close #26783
Checklist
Socials
https://twitter.com/MainakDeb19