fix: Add missing job name for .github\workflows\binaries.yml
#26867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vedpatwardhan sir, I have made the PR adding the missing job name (#26867). Please look into this PR when you are free, If you think there should be a better |
vedpatwardhan
suggested changes
Oct 11, 2023
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
p1utoze
pushed a commit
to p1utoze/ivy
that referenced
this pull request
Oct 13, 2023
…lc#26867) Co-authored-by: vedpatwardhan <[email protected]>
p1utoze
pushed a commit
to p1utoze/ivy
that referenced
this pull request
Oct 13, 2023
…lc#26867) Co-authored-by: vedpatwardhan <[email protected]>
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
…lc#26867) Co-authored-by: vedpatwardhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added the missing job name for the
.github\workflows\binaries.ymlWorkflow.https://github.com/unifyai/ivy/blob/8608b7f9cda83f78b3409eaa33a47701c76bfa21/.github/workflows/binaries.yml#L4
I'm not sure about the name but I guess something like
release_binaries:ortag_binary_release:could be added.Related Issue
Closes #26856
Checklist
Socials
https://twitter.com/Sai_Suraj_27