Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stft #27112

Conversation

muhammadhammad-tech
Copy link
Contributor

@muhammadhammad-tech muhammadhammad-tech commented Oct 24, 2023

Fixes #26989

PR Description

Need help with the test function

Related Issue

Closes #26989

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Twitter: https://twitter.com/hammad98007

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 24, 2023
@aparajith21
Copy link
Contributor

Hey, thanks for contributing! As mentioned by the bot in an earlier comment, please ensure that the PR title adheres to conventional commit standards. Further, fully populate the checklist (i.e. run the tests and confirm that they pass) so i know it is ready for review!

@muhammadhammad-tech
Copy link
Contributor Author

muhammadhammad-tech commented Oct 27, 2023

@aparajith21 would be able to help me in tests cases i think i am doing something wrong but unable to point, do i need to implement stft layers.py according to paddle cause at the moment there some parameters that it do not accept. would appreciate your feedback thank you.

@muhammadhammad-tech muhammadhammad-tech changed the title stft feat: add stft method to paddle frontend Oct 27, 2023
@Sarvesh-Kesharwani Sarvesh-Kesharwani changed the title feat: add stft method to paddle frontend stft Jan 10, 2024
@Sarvesh-Kesharwani
Copy link
Contributor

Sarvesh-Kesharwani commented Jan 10, 2024

This issue belongs to this Issue Dashboard: #15049

@Sarvesh-Kesharwani
Copy link
Contributor

@aparajith21 would be able to help me in tests cases i think i am doing something wrong but unable to point, do i need to implement stft layers.py according to paddle cause at the moment there some parameters that it do not accept. would appreciate your feedback thank you.

Please try to fix this error:
image

and right now all the test cases are failing.
image

@Ishticode
Copy link
Contributor

Closing this due to inactivity for over 2 months after changes were requested. Please feel free to reopen if you would like to continue work on this. Thank you :)

@Ishticode Ishticode closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stft
5 participants