-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function grid_sample.py #27915
function grid_sample.py #27915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
I have done the code but I have some errors I got stuck in, can you help me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.
For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪
If you want to check them from the action runners, you can open the display_test_results
job. 👀
It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that fail on this PR.
Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.
@ivy-branch @joaozenobio |
Please I need help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mostafaosama4
Thanks for the PR.
Could you clarify in what regards do you need help?
Few requests. Could you please add the accompanying test for this function. Also the addition of function in vision.py is fine but the creation of a file grid_sample.py is not what we should do so can we please remove that. Thnx
I had a problem in running the code, I used pycharm with docker interpreter and run my code 'pytest nn frontends' and also with other ways and the code didn't run because of many errors, I tried to solve them but I couldn't. I want help to make the code run correctly, also I will try again today and will provide you a screenshot with the errors if the problem still exists. File grid_sample.py is deleted. |
Closing this as the function is already added in 8cf4dc7 by about 4 months prior to this PR. |
PR Description
Related Issue
Closes #27853
Checklist
Socials