adding Relu in raw_ops tensorflow frontend #4780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close #4779 |
ivy-leaves
added
the
TensorFlow Frontend
iamjameskeane
suggested changes
Sep 22, 2022
| @@ -142,3 +142,6 @@ def Transpose(*, x, perm, name="Transpose"): | |||
|
|
|||
| def ZerosLike(*, x, name="ZerosLike"): | |||
| return ivy.zeros_like(x) | |||
|
|
|||
| def Relu(features, name=None): | |||
There was a problem hiding this comment.
name should be "Relu" just to match the rest of the functions in this module
There was a problem hiding this comment.
Hello, @jkeane508 , thank you very much for the review. I've replaced the name with "Relu". Although "lint / check-formatting (pull_request)" checks were successful, I am not sure exactly why "test-frontend-tensorflow / run-nightly-tests (pull_request)" checks were failing.
There was a problem hiding this comment.
Yea I've looked at the test errors, seems to be an issue with the num_positional_args in the test. I would suggest hardcoding the number of positional args rather than using the helper and see if this helps. I'm aware that currently there is an issue with this
iamjameskeane
suggested changes
Sep 23, 2022
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_raw_ops.py
Outdated
Show resolved
Hide resolved
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_raw_ops.py
Outdated
Show resolved
Hide resolved
kcsayem
force-pushed
the
tensor_instance_reshape
branch
from
ef9f6c9 to
b36eb0c
Compare
iamjameskeane
approved these changes
Sep 24, 2022
kcsayem
force-pushed
the
tensor_instance_reshape
branch
from
b36eb0c to
82124aa
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.